public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel•org>
To: Ido Schimmel <idosch@idosch•org>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	"netdev-driver-reviewers@vger•kernel.org"
	<netdev-driver-reviewers@vger•kernel.org>
Subject: Re: [TEST] bridge tests (was: net-next is OPEN)
Date: Thu, 8 Feb 2024 09:26:08 -0800	[thread overview]
Message-ID: <20240208092608.3765b222@kernel.org> (raw)
In-Reply-To: <ZcT_iSwnYmORF-8A@shredder>

On Thu, 8 Feb 2024 18:21:29 +0200 Ido Schimmel wrote:
> On Thu, Feb 01, 2024 at 04:16:19PM -0800, Jakub Kicinski wrote:
> > On Thu, 1 Feb 2024 07:30:25 -0800 Jakub Kicinski wrote:  
> > > Ah, ugh, sorry for the misdirection, you're right.  
> > 
> > Confirmed, with the SUID cleared test-bridge-neigh-suppress-sh now
> > passes on everything with the exception of metal+debug kernel.  
> 
> I'm sorry for bothering you with this, 

No worries at all :)

> but I checked today's logs and it
> seems there is a similar problem with arping:
> https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/456561/8-test-bridge-neigh-suppress-sh/stdout
> https://netdev-3.bots.linux.dev/vmksft-net/results/456562/6-test-bridge-neigh-suppress-sh/stdout
> 
> And according to this log the ndisc6 problem resurfaced:
> https://netdev-3.bots.linux.dev/vmksft-net/results/456382/6-test-bridge-neigh-suppress-sh/stdout

It seems pretty faily:

https://netdev.bots.linux.dev/flakes.html?br-cnt=80&tn-needle=bridge-neigh&min-flip=0

I guess the short green streak does coincide with the fix, tho. Hm.

> Any chance that something in the OS changed since last week?

My memory is bad so I started keeping a log:

https://docs.google.com/spreadsheets/d/1mFnt91SKtA9ENIUfY0v2UmZSXJzmvsa4oqha4t6JVBs/edit?pli=1#gid=338019672

But it's not the suid:

$ find tools/fs/ -perm -4000
$ ll $(find tools/fs/ -name arping)
-rwxr-xr-x. 1 virtme virtme 79360 Jan 29 14:38 tools/fs/usr/bin/arping
$ ll $(find tools/fs/ -name ndisc6)
-rwxr-xr-x. 1 virtme virtme 53840 Jan 29 14:36 tools/fs/usr/bin/ndisc6

And it occasionally blips to "pass" so can't be completely broken env.

I run the test now with VERBOSE=1 and -q removed from arping and ndisc6:
https://netdev-3.bots.linux.dev/vmksft-net/test_bridge_neigh_suppress/

It just says: Received 0 response(s) :(

Repro is 100%, LMK if you'd like me to try with some custom diff on
top..

      reply	other threads:[~2024-02-08 17:26 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 17:16 [ANN] net-next is OPEN Jakub Kicinski
2024-01-22 20:54 ` Simon Horman
2024-01-23  8:45 ` Hangbin Liu
2024-01-23 15:20   ` Jakub Kicinski
2024-01-23 16:51     ` David Ahern
2024-01-23 21:39       ` Jakub Kicinski
2024-01-24  5:20         ` David Ahern
2024-01-24  8:22           ` Paolo Abeni
2024-01-24 15:07             ` Jakub Kicinski
2024-01-24 16:19               ` Jakub Kicinski
2024-01-24 16:35                 ` David Ahern
2024-01-24 16:59                   ` Jakub Kicinski
2024-01-24 21:48                     ` David Ahern
2024-01-27  0:56                       ` David Ahern
2024-01-27  1:13                         ` Jakub Kicinski
2024-01-28  4:26                           ` David Ahern
2024-01-29  9:23                             ` Paolo Abeni
2024-01-29 15:03                               ` Jakub Kicinski
2024-01-29 15:32                                 ` David Ahern
2024-01-29 16:53                                   ` Jakub Kicinski
2024-01-24 15:59       ` Willem de Bruijn
2024-01-24 16:22         ` Jakub Kicinski
2024-01-24 17:01           ` Jakub Kicinski
2024-01-24 18:35             ` Matthieu Baerts
2024-01-24 19:00               ` Jakub Kicinski
2024-01-24 19:18               ` [netfilter-core] " Pablo Neira Ayuso
2024-02-06 18:31                 ` Matthieu Baerts
2024-02-07  9:49                   ` Pablo Neira Ayuso
2024-02-07 11:33                     ` Matthieu Baerts
2024-02-16 15:38                       ` Pablo Neira Ayuso
2024-02-16 15:51                         ` Matthieu Baerts
2024-01-24 19:16             ` Pablo Neira Ayuso
2024-01-24 19:40               ` Jakub Kicinski
2024-01-24 20:02                 ` Pablo Neira Ayuso
2024-01-24 20:13                   ` Jakub Kicinski
2024-01-25  5:07                     ` Jakub Kicinski
2024-01-25  8:52                       ` Florian Westphal
2024-01-25 17:30                         ` Jakub Kicinski
2024-01-25  9:29                       ` Pablo Neira Ayuso
2024-01-25 17:34                         ` Jakub Kicinski
2024-01-24 17:42           ` Willem de Bruijn
2024-01-24 17:49             ` Jakub Kicinski
2024-01-24 18:23               ` Willem de Bruijn
2024-01-24 18:31                 ` Paolo Abeni
2024-01-23  9:55 ` Petr Machata
2024-01-23 12:42   ` Matthias May
2024-01-23 13:38     ` Petr Machata
2024-01-23 15:30       ` Jakub Kicinski
2024-01-23 16:05         ` Petr Machata
2024-01-23 16:33           ` Jakub Kicinski
2024-01-23 15:34   ` Jakub Kicinski
2024-01-23 17:04     ` Petr Machata
2024-01-23 17:38       ` Jakub Kicinski
2024-01-24 11:06         ` Petr Machata
2024-01-29 12:43 ` Ido Schimmel
2024-01-29 12:46   ` Ido Schimmel
2024-01-29 15:00     ` Jakub Kicinski
2024-01-29 17:00       ` Ido Schimmel
2024-01-29 17:18         ` Jakub Kicinski
2024-01-31 13:23           ` Ido Schimmel
2024-01-31 14:16             ` Heiner Kallweit
2024-01-31 16:01             ` [TEST] bridge tests (was: net-next is OPEN) Jakub Kicinski
2024-02-01 13:46               ` Ido Schimmel
2024-02-01 15:30                 ` Jakub Kicinski
2024-02-02  0:16                   ` Jakub Kicinski
2024-02-08 16:21                     ` Ido Schimmel
2024-02-08 17:26                       ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240208092608.3765b222@kernel.org \
    --to=kuba@kernel$(echo .)org \
    --cc=idosch@idosch$(echo .)org \
    --cc=netdev-driver-reviewers@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox