From: Petr Machata <petrm@nvidia•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Petr Machata <petrm@nvidia•com>, Shuah Khan <shuah@kernel•org>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"netdev-driver-reviewers@vger•kernel.org"
<netdev-driver-reviewers@vger•kernel.org>,
<linux-kselftest@vger•kernel.org>
Subject: Re: [ANN] net-next is OPEN
Date: Wed, 24 Jan 2024 12:06:00 +0100 [thread overview]
Message-ID: <87ede5n5oc.fsf@nvidia.com> (raw)
In-Reply-To: <20240123093834.23ea172a@kernel.org>
Jakub Kicinski <kuba@kernel•org> writes:
> On Tue, 23 Jan 2024 18:04:19 +0100 Petr Machata wrote:
>> > Unless I'm doing it wrong and the sub-directories are supposed to
>> > inherit the parent directory's config? So net/forwarding/ should
>> > be built with net/'s config? I could not find the info in docs,
>> > does anyone know?
>>
>> I don't think they are, net/config defines CONFIG_VXLAN, but then the
>> vxlan tests still complain about unknown device type. Though maybe
>> there's another device type that it's missing...
>>
>> What do I do to feed the config file to some build script to get a
>> kernel image to test? I can of course just do something like
>> cat config | xargs -n1 scripts/config -m, but I expect there's some
>> automation for it and I just can't find it.
>
> The CI script is based on virtme-ng. So it does this:
>
> # $target is net or net/forwarding or drivers/net/bonding etc.
> make mrproper
> vng -v -b -f tools/testing/selftests/$target
Actually:
# vng -v -b -f tools/testing/selftests/${target}/config
Didn't know about vng, it's way cool!
(Despite having used virtme for a long time.)
> # build the scripts
> make headers
> make -C tools/testing/selftests/$target
>
> vng -v -r arch/x86/boot/bzImage --user root
> # inside the VM
> make -C tools/testing/selftests TARGETS=$target run_tests
I'm working my way through the selftests.
> https://github.com/kuba-moo/nipa/blob/master/contest/remote/vmksft.py#L138
>
> You're right, it definitely does not "inherit" net's config when
> running forwarding/net. I can easily make it do so, but I'm not clear
>
> what the expectation from the kselftest subsystem is. Because if other
> testers (people testing stable, KernelCI etc. et.c) don't "inherit" we
> better fill in the config completely so that the tests pass for
> everyone.
Oh, gotcha, the question was not whether it does, but whether it's
supposed to. OK.
IMHO not necessarily. net/config is for net/*.sh, net/forwarding/config
for net/forwarding/*.sh. It's not a given that whatever is needed for
net/ is needed for net/forwarding/ as well.
It will also lead to simpler patches, where enabling config options in
X/ doesn't imply checking for newly useless duplicities in X's child
directories.
next prev parent reply other threads:[~2024-01-25 9:06 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 17:16 [ANN] net-next is OPEN Jakub Kicinski
2024-01-22 20:54 ` Simon Horman
2024-01-23 8:45 ` Hangbin Liu
2024-01-23 15:20 ` Jakub Kicinski
2024-01-23 16:51 ` David Ahern
2024-01-23 21:39 ` Jakub Kicinski
2024-01-24 5:20 ` David Ahern
2024-01-24 8:22 ` Paolo Abeni
2024-01-24 15:07 ` Jakub Kicinski
2024-01-24 16:19 ` Jakub Kicinski
2024-01-24 16:35 ` David Ahern
2024-01-24 16:59 ` Jakub Kicinski
2024-01-24 21:48 ` David Ahern
2024-01-27 0:56 ` David Ahern
2024-01-27 1:13 ` Jakub Kicinski
2024-01-28 4:26 ` David Ahern
2024-01-29 9:23 ` Paolo Abeni
2024-01-29 15:03 ` Jakub Kicinski
2024-01-29 15:32 ` David Ahern
2024-01-29 16:53 ` Jakub Kicinski
2024-01-24 15:59 ` Willem de Bruijn
2024-01-24 16:22 ` Jakub Kicinski
2024-01-24 17:01 ` Jakub Kicinski
2024-01-24 18:35 ` Matthieu Baerts
2024-01-24 19:00 ` Jakub Kicinski
2024-01-24 19:18 ` [netfilter-core] " Pablo Neira Ayuso
2024-02-06 18:31 ` Matthieu Baerts
2024-02-07 9:49 ` Pablo Neira Ayuso
2024-02-07 11:33 ` Matthieu Baerts
2024-02-16 15:38 ` Pablo Neira Ayuso
2024-02-16 15:51 ` Matthieu Baerts
2024-01-24 19:16 ` Pablo Neira Ayuso
2024-01-24 19:40 ` Jakub Kicinski
2024-01-24 20:02 ` Pablo Neira Ayuso
2024-01-24 20:13 ` Jakub Kicinski
2024-01-25 5:07 ` Jakub Kicinski
2024-01-25 8:52 ` Florian Westphal
2024-01-25 17:30 ` Jakub Kicinski
2024-01-25 9:29 ` Pablo Neira Ayuso
2024-01-25 17:34 ` Jakub Kicinski
2024-01-24 17:42 ` Willem de Bruijn
2024-01-24 17:49 ` Jakub Kicinski
2024-01-24 18:23 ` Willem de Bruijn
2024-01-24 18:31 ` Paolo Abeni
2024-01-23 9:55 ` Petr Machata
2024-01-23 12:42 ` Matthias May
2024-01-23 13:38 ` Petr Machata
2024-01-23 15:30 ` Jakub Kicinski
2024-01-23 16:05 ` Petr Machata
2024-01-23 16:33 ` Jakub Kicinski
2024-01-23 15:34 ` Jakub Kicinski
2024-01-23 17:04 ` Petr Machata
2024-01-23 17:38 ` Jakub Kicinski
2024-01-24 11:06 ` Petr Machata [this message]
2024-01-29 12:43 ` Ido Schimmel
2024-01-29 12:46 ` Ido Schimmel
2024-01-29 15:00 ` Jakub Kicinski
2024-01-29 17:00 ` Ido Schimmel
2024-01-29 17:18 ` Jakub Kicinski
2024-01-31 13:23 ` Ido Schimmel
2024-01-31 14:16 ` Heiner Kallweit
2024-01-31 16:01 ` [TEST] bridge tests (was: net-next is OPEN) Jakub Kicinski
2024-02-01 13:46 ` Ido Schimmel
2024-02-01 15:30 ` Jakub Kicinski
2024-02-02 0:16 ` Jakub Kicinski
2024-02-08 16:21 ` Ido Schimmel
2024-02-08 17:26 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2026-04-27 22:47 [ANN] net-next is OPEN Jakub Kicinski
2026-02-23 15:37 Jakub Kicinski
2026-01-04 15:03 Jakub Kicinski
2025-10-13 13:03 Paolo Abeni
2025-08-11 14:01 Jakub Kicinski
2025-06-09 14:34 Jakub Kicinski
2025-04-07 12:54 Jakub Kicinski
2025-02-03 14:54 Jakub Kicinski
2025-01-02 16:48 Jakub Kicinski
2024-12-02 14:36 Jakub Kicinski
2024-09-30 11:48 Jakub Kicinski
2024-07-29 15:05 Jakub Kicinski
2024-05-27 16:00 Jakub Kicinski
2024-03-25 13:42 Jakub Kicinski
2023-11-13 16:30 Jakub Kicinski
2023-09-11 20:17 Paolo Abeni
2023-09-11 20:38 ` Nelson, Shannon
2023-07-10 17:48 Jakub Kicinski
2023-05-08 16:23 Jakub Kicinski
2023-05-09 6:09 ` Michal Schmidt
2023-03-06 17:28 Jakub Kicinski
2023-01-03 20:24 Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ede5n5oc.fsf@nvidia.com \
--to=petrm@nvidia$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=netdev-driver-reviewers@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=shuah@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox