public inbox for netdev@vger.kernel.org 
 help / color / mirror / Atom feed
From: Petr Machata <petrm@nvidia•com>
To: Jakub Kicinski <kuba@kernel•org>
Cc: "netdev@vger•kernel.org" <netdev@vger•kernel.org>,
	"netdev-driver-reviewers@vger•kernel.org"
	<netdev-driver-reviewers@vger•kernel.org>
Subject: Re: [ANN] net-next is OPEN
Date: Tue, 23 Jan 2024 10:55:09 +0100	[thread overview]
Message-ID: <87fryonx35.fsf@nvidia.com> (raw)
In-Reply-To: <20240122091612.3f1a3e3d@kernel.org>


Jakub Kicinski <kuba@kernel•org> writes:

> If you authored any net or drivers/net selftests, please look around
> and see if they are passing. If not - send patches or LMK what I need
> to do to make them pass on the runner.. Make sure to scroll down to 
> the "Not reporting to patchwork" section.

A whole bunch of them fail because of no IPv6 support in the runner
kernel. E.g. this from bridge-mdb.sh[0]:

    # Error: Rule family not supported.
    # Error: Rule family not supported.
    # sysctl: cannot stat /proc/sys/net/ipv6/conf/all/forwarding: No such file or directory
    # sysctl: cannot stat /proc/sys/net/ipv6/conf/all/forwarding: No such file or directory
    # RTNETLINK answers: Operation not supported

I'm surprised any passed at all, it's super common for tests to validate
their topology by pinging through, but I guess it's often just IPv4. I
think the fix is just this?

    $ scripts/config -k -m CONFIG_IPV6

There are also a bunch of missing qdiscs, e.g. in [1], [2]. To fix:

    $ scripts/config -k -m CONFIG_NET_SCH_TBF
    $ scripts/config -k -m CONFIG_NET_SCH_PRIO
    $ scripts/config -k -m CONFIG_NET_SCH_ETS

Regarding sch_red.sh[3], I worry the test will be noisy, and suspect it
does not make sense to run it in automated fashion. But if you think
it's worth a try:

    $ scripts/config -k -m CONFIG_NET_SCH_RED

Then there are a bunch of missing netdevices. VXLAN[4]:

    $ scripts/config -k -m CONFIG_VXLAN

and GRE [5], which I think needs all of these:

    $ scripts/config -k -m CONFIG_NET_IPIP
    $ scripts/config -k -m CONFIG_IPV6_GRE
    $ scripts/config -k -m CONFIG_NET_IPGRE_DEMUX
    $ scripts/config -k -m CONFIG_NET_IPGRE

And TC actions [6]. I think the following will be necessary for some of
the tests (we enable BPF as well internally).

    $ scripts/config -k -m CONFIG_NET_ACT_GACT
    $ scripts/config -k -m CONFIG_NET_ACT_MIRRED
    $ scripts/config -k -m CONFIG_NET_ACT_SAMPLE
    $ scripts/config -k -m CONFIG_NET_ACT_VLAN
    $ scripts/config -k -m CONFIG_NET_ACT_SKBEDIT
    $ scripts/config -k -m CONFIG_NET_ACT_PEDIT
    $ scripts/config -k -m CONFIG_NET_ACT_POLICE

Hopefully the above should clean up the results a bit, I can take
another sweep afterwards.

[0] https://netdev-2.bots.linux.dev/vmksft-forwarding/results/433341/14-bridge-mdb-sh/stdout
[1] https://netdev-2.bots.linux.dev/vmksft-forwarding/results/433341/17-sch-ets-sh/stdout
[2] https://netdev-2.bots.linux.dev/vmksft-forwarding/results/433341/33-sch-tbf-prio-sh/stdout
[3] https://netdev-2.bots.linux.dev/vmksft-forwarding/results/433341/21-sch-red-sh/stdout
[4] https://netdev-2.bots.linux.dev/vmksft-forwarding/results/433341/27-mirror-gre-changes-sh/stdout
[5] https://netdev-2.bots.linux.dev/vmksft-forwarding/results/433341/18-vxlan-bridge-1d-sh/stdout
[6] https://netdev-2.bots.linux.dev/vmksft-forwarding/results/433341/42-pedit-l4port-sh/stdout

  parent reply	other threads:[~2024-01-23 10:50 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 17:16 [ANN] net-next is OPEN Jakub Kicinski
2024-01-22 20:54 ` Simon Horman
2024-01-23  8:45 ` Hangbin Liu
2024-01-23 15:20   ` Jakub Kicinski
2024-01-23 16:51     ` David Ahern
2024-01-23 21:39       ` Jakub Kicinski
2024-01-24  5:20         ` David Ahern
2024-01-24  8:22           ` Paolo Abeni
2024-01-24 15:07             ` Jakub Kicinski
2024-01-24 16:19               ` Jakub Kicinski
2024-01-24 16:35                 ` David Ahern
2024-01-24 16:59                   ` Jakub Kicinski
2024-01-24 21:48                     ` David Ahern
2024-01-27  0:56                       ` David Ahern
2024-01-27  1:13                         ` Jakub Kicinski
2024-01-28  4:26                           ` David Ahern
2024-01-29  9:23                             ` Paolo Abeni
2024-01-29 15:03                               ` Jakub Kicinski
2024-01-29 15:32                                 ` David Ahern
2024-01-29 16:53                                   ` Jakub Kicinski
2024-01-24 15:59       ` Willem de Bruijn
2024-01-24 16:22         ` Jakub Kicinski
2024-01-24 17:01           ` Jakub Kicinski
2024-01-24 18:35             ` Matthieu Baerts
2024-01-24 19:00               ` Jakub Kicinski
2024-01-24 19:18               ` [netfilter-core] " Pablo Neira Ayuso
2024-02-06 18:31                 ` Matthieu Baerts
2024-02-07  9:49                   ` Pablo Neira Ayuso
2024-02-07 11:33                     ` Matthieu Baerts
2024-02-16 15:38                       ` Pablo Neira Ayuso
2024-02-16 15:51                         ` Matthieu Baerts
2024-01-24 19:16             ` Pablo Neira Ayuso
2024-01-24 19:40               ` Jakub Kicinski
2024-01-24 20:02                 ` Pablo Neira Ayuso
2024-01-24 20:13                   ` Jakub Kicinski
2024-01-25  5:07                     ` Jakub Kicinski
2024-01-25  8:52                       ` Florian Westphal
2024-01-25 17:30                         ` Jakub Kicinski
2024-01-25  9:29                       ` Pablo Neira Ayuso
2024-01-25 17:34                         ` Jakub Kicinski
2024-01-24 17:42           ` Willem de Bruijn
2024-01-24 17:49             ` Jakub Kicinski
2024-01-24 18:23               ` Willem de Bruijn
2024-01-24 18:31                 ` Paolo Abeni
2024-01-23  9:55 ` Petr Machata [this message]
2024-01-23 12:42   ` Matthias May
2024-01-23 13:38     ` Petr Machata
2024-01-23 15:30       ` Jakub Kicinski
2024-01-23 16:05         ` Petr Machata
2024-01-23 16:33           ` Jakub Kicinski
2024-01-23 15:34   ` Jakub Kicinski
2024-01-23 17:04     ` Petr Machata
2024-01-23 17:38       ` Jakub Kicinski
2024-01-24 11:06         ` Petr Machata
2024-01-29 12:43 ` Ido Schimmel
2024-01-29 12:46   ` Ido Schimmel
2024-01-29 15:00     ` Jakub Kicinski
2024-01-29 17:00       ` Ido Schimmel
2024-01-29 17:18         ` Jakub Kicinski
2024-01-31 13:23           ` Ido Schimmel
2024-01-31 14:16             ` Heiner Kallweit
2024-01-31 16:01             ` [TEST] bridge tests (was: net-next is OPEN) Jakub Kicinski
2024-02-01 13:46               ` Ido Schimmel
2024-02-01 15:30                 ` Jakub Kicinski
2024-02-02  0:16                   ` Jakub Kicinski
2024-02-08 16:21                     ` Ido Schimmel
2024-02-08 17:26                       ` Jakub Kicinski
  -- strict thread matches above, loose matches on Subject: below --
2026-04-27 22:47 [ANN] net-next is OPEN Jakub Kicinski
2026-02-23 15:37 Jakub Kicinski
2026-01-04 15:03 Jakub Kicinski
2025-10-13 13:03 Paolo Abeni
2025-08-11 14:01 Jakub Kicinski
2025-06-09 14:34 Jakub Kicinski
2025-04-07 12:54 Jakub Kicinski
2025-02-03 14:54 Jakub Kicinski
2025-01-02 16:48 Jakub Kicinski
2024-12-02 14:36 Jakub Kicinski
2024-09-30 11:48 Jakub Kicinski
2024-07-29 15:05 Jakub Kicinski
2024-05-27 16:00 Jakub Kicinski
2024-03-25 13:42 Jakub Kicinski
2023-11-13 16:30 Jakub Kicinski
2023-09-11 20:17 Paolo Abeni
2023-09-11 20:38 ` Nelson, Shannon
2023-07-10 17:48 Jakub Kicinski
2023-05-08 16:23 Jakub Kicinski
2023-05-09  6:09 ` Michal Schmidt
2023-03-06 17:28 Jakub Kicinski
2023-01-03 20:24 Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fryonx35.fsf@nvidia.com \
    --to=petrm@nvidia$(echo .)com \
    --cc=kuba@kernel$(echo .)org \
    --cc=netdev-driver-reviewers@vger$(echo .)kernel.org \
    --cc=netdev@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox