From: David Ahern <dsahern@kernel•org>
To: Jakub Kicinski <kuba@kernel•org>
Cc: Hangbin Liu <liuhangbin@gmail•com>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>,
"netdev-driver-reviewers@vger•kernel.org"
<netdev-driver-reviewers@vger•kernel.org>
Subject: Re: [ANN] net-next is OPEN
Date: Tue, 23 Jan 2024 22:20:22 -0700 [thread overview]
Message-ID: <256ae085-bf8f-419b-bcea-8cdce1b64dce@kernel.org> (raw)
In-Reply-To: <20240123133925.4b8babdc@kernel.org>
On 1/23/24 2:39 PM, Jakub Kicinski wrote:
> On Tue, 23 Jan 2024 09:51:07 -0700 David Ahern wrote:
>> Really cool. Thanks for spending time to make this happen.
>>
>> Scanning the tests I wrote, I think most of the failures are config
>> related. e.g., fib-nexthops.sh needs MPLS and those config settings are
>> enabled in tools/testing/selftests/net/config.
>>
>> Another one, fcnal-test, needs nettest built. From
>> https://netdev-2.bots.linux.dev/vmksft-net/results/432660/36-fcnal-test-sh:
>>
>> # which: no nettest in
>> (/home/virtme/tools/fs/bin:/home/virtme/tools/fs/sbin:/home/virtme/tools/fs/usr/bin:/home/virtme/tools/fs/usr/sbin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/local/bin)
>>
>> It is in the Makefile, so how should that dependency be defined for this
>> new environment?
>
> We run the tests with
>
> make -C tools/testing/selftests TARGETS=net run_tests
thanks for the tip to direclty run the tests.
>
> the binary is there:
>
> $ ls tools/testing/selftests/net/nettest
> tools/testing/selftests/net/nettest
>
> The script does:
>
> if ! which nettest >/dev/null; then
> PATH=$PWD:$PATH
> if ! which nettest >/dev/null; then
> echo "'nettest' command not found; skipping tests"
> exit $ksft_skip
> fi
> fi
This fixes the PATH problem:
diff --git a/tools/testing/selftests/net/fcnal-test.sh
b/tools/testing/selftests/net/fcnal-test.sh
index a8ad92850e63..0c5ac117155d 100755
--- a/tools/testing/selftests/net/fcnal-test.sh
+++ b/tools/testing/selftests/net/fcnal-test.sh
@@ -37,6 +37,8 @@
#
# server / client nomenclature relative to ns-A
+PATH=$PWD:$PWD/tools/testing/selftests/net:$PATH
+
VERBOSE=0
NSA_DEV=eth1
but given the permutations it does, the script needs lot more than 45
seconds. This does the trick, but not sure how to bump the timeout for a
specific test.
diff --git a/tools/testing/selftests/kselftest/runner.sh
b/tools/testing/selftests/kselftest/runner.sh
index cc9c846585f0..9e7dcb728249 100644
--- a/tools/testing/selftests/kselftest/runner.sh
+++ b/tools/testing/selftests/kselftest/runner.sh
@@ -9,7 +9,7 @@ export per_test_logging=
# Defaults for "settings" file fields:
# "timeout" how many seconds to let each test run before failing.
-export kselftest_default_timeout=45
+export kselftest_default_timeout=3600
# There isn't a shell-agnostic way to find the path of a sourced file,
# so we must rely on BASE_DIR being set to find other tools.
next prev parent reply other threads:[~2024-01-24 5:20 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 17:16 [ANN] net-next is OPEN Jakub Kicinski
2024-01-22 20:54 ` Simon Horman
2024-01-23 8:45 ` Hangbin Liu
2024-01-23 15:20 ` Jakub Kicinski
2024-01-23 16:51 ` David Ahern
2024-01-23 21:39 ` Jakub Kicinski
2024-01-24 5:20 ` David Ahern [this message]
2024-01-24 8:22 ` Paolo Abeni
2024-01-24 15:07 ` Jakub Kicinski
2024-01-24 16:19 ` Jakub Kicinski
2024-01-24 16:35 ` David Ahern
2024-01-24 16:59 ` Jakub Kicinski
2024-01-24 21:48 ` David Ahern
2024-01-27 0:56 ` David Ahern
2024-01-27 1:13 ` Jakub Kicinski
2024-01-28 4:26 ` David Ahern
2024-01-29 9:23 ` Paolo Abeni
2024-01-29 15:03 ` Jakub Kicinski
2024-01-29 15:32 ` David Ahern
2024-01-29 16:53 ` Jakub Kicinski
2024-01-24 15:59 ` Willem de Bruijn
2024-01-24 16:22 ` Jakub Kicinski
2024-01-24 17:01 ` Jakub Kicinski
2024-01-24 18:35 ` Matthieu Baerts
2024-01-24 19:00 ` Jakub Kicinski
2024-01-24 19:18 ` [netfilter-core] " Pablo Neira Ayuso
2024-02-06 18:31 ` Matthieu Baerts
2024-02-07 9:49 ` Pablo Neira Ayuso
2024-02-07 11:33 ` Matthieu Baerts
2024-02-16 15:38 ` Pablo Neira Ayuso
2024-02-16 15:51 ` Matthieu Baerts
2024-01-24 19:16 ` Pablo Neira Ayuso
2024-01-24 19:40 ` Jakub Kicinski
2024-01-24 20:02 ` Pablo Neira Ayuso
2024-01-24 20:13 ` Jakub Kicinski
2024-01-25 5:07 ` Jakub Kicinski
2024-01-25 8:52 ` Florian Westphal
2024-01-25 17:30 ` Jakub Kicinski
2024-01-25 9:29 ` Pablo Neira Ayuso
2024-01-25 17:34 ` Jakub Kicinski
2024-01-24 17:42 ` Willem de Bruijn
2024-01-24 17:49 ` Jakub Kicinski
2024-01-24 18:23 ` Willem de Bruijn
2024-01-24 18:31 ` Paolo Abeni
2024-01-23 9:55 ` Petr Machata
2024-01-23 12:42 ` Matthias May
2024-01-23 13:38 ` Petr Machata
2024-01-23 15:30 ` Jakub Kicinski
2024-01-23 16:05 ` Petr Machata
2024-01-23 16:33 ` Jakub Kicinski
2024-01-23 15:34 ` Jakub Kicinski
2024-01-23 17:04 ` Petr Machata
2024-01-23 17:38 ` Jakub Kicinski
2024-01-24 11:06 ` Petr Machata
2024-01-29 12:43 ` Ido Schimmel
2024-01-29 12:46 ` Ido Schimmel
2024-01-29 15:00 ` Jakub Kicinski
2024-01-29 17:00 ` Ido Schimmel
2024-01-29 17:18 ` Jakub Kicinski
2024-01-31 13:23 ` Ido Schimmel
2024-01-31 14:16 ` Heiner Kallweit
2024-01-31 16:01 ` [TEST] bridge tests (was: net-next is OPEN) Jakub Kicinski
2024-02-01 13:46 ` Ido Schimmel
2024-02-01 15:30 ` Jakub Kicinski
2024-02-02 0:16 ` Jakub Kicinski
2024-02-08 16:21 ` Ido Schimmel
2024-02-08 17:26 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2026-04-27 22:47 [ANN] net-next is OPEN Jakub Kicinski
2026-02-23 15:37 Jakub Kicinski
2026-01-04 15:03 Jakub Kicinski
2025-10-13 13:03 Paolo Abeni
2025-08-11 14:01 Jakub Kicinski
2025-06-09 14:34 Jakub Kicinski
2025-04-07 12:54 Jakub Kicinski
2025-02-03 14:54 Jakub Kicinski
2025-01-02 16:48 Jakub Kicinski
2024-12-02 14:36 Jakub Kicinski
2024-09-30 11:48 Jakub Kicinski
2024-07-29 15:05 Jakub Kicinski
2024-05-27 16:00 Jakub Kicinski
2024-03-25 13:42 Jakub Kicinski
2023-11-13 16:30 Jakub Kicinski
2023-09-11 20:17 Paolo Abeni
2023-09-11 20:38 ` Nelson, Shannon
2023-07-10 17:48 Jakub Kicinski
2023-05-08 16:23 Jakub Kicinski
2023-05-09 6:09 ` Michal Schmidt
2023-03-06 17:28 Jakub Kicinski
2023-01-03 20:24 Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=256ae085-bf8f-419b-bcea-8cdce1b64dce@kernel.org \
--to=dsahern@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=netdev-driver-reviewers@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox