From: roopa <roopa@cumulusnetworks•com>
To: Robert Shearman <rshearma@brocade•com>
Cc: ebiederm@xmission•com, tgraf@suug•ch, davem@davemloft•net,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels
Date: Fri, 19 Jun 2015 08:14:11 -0700 [thread overview]
Message-ID: <558431C3.5020703@cumulusnetworks.com> (raw)
In-Reply-To: <55842A93.2040607@brocade.com>
On 6/19/15, 7:43 AM, Robert Shearman wrote:
>> diff --git a/include/linux/lwtunnel.h b/include/linux/lwtunnel.h
>> new file mode 100644
<snip>
>> +/* lw tunnel state flags */
>> +#define LWTUNNEL_STATE_OUTPUT_REDIRECT 0x1
>> +
>> +#define lwtunnel_output_redirect(lwtstate) (lwtstate && \
>> + (lwtstate->flags & LWTUNNEL_STATE_OUTPUT_REDIRECT))
>
> This could be made an inline function for type-safety.
ack
>
>> +
>> +struct lwtunnel_state {
>> + __u16 type;
>> + __u16 flags;
>> + atomic_t refcnt;
>> + struct lwtunnel_hdr tunnel;
>> +};
>> +
>> +struct lwtunnel_net {
>> + struct hlist_head tunnels[LWTUNNEL_HASH_SIZE];
>> +};
>
> This type doesn't appear to be used in this patch series. Do you
> intend to use it in a future version?
ack, will get rid of it
>
>>
>> +
>> +static inline struct lwtunnel_state *lwtunnel_skb_lwstate(struct
>> sk_buff *skb)
>> +{
>> + struct rtable *rt = (struct rtable *)skb_dst(skb);
>> +
>> + return rt->rt_lwtstate;
>> +}
>
> It doesn't look like this patch will build on its own because
> rt_lwtstate isn't added to struct rtable until patch 2.
looks like i messed up the patch creation. I will fix that with the next
series.
>
> More importantly, is it safe to assume that skb_dst will always return
> an IPv4 dst? How will this look when IPv6 support is added?
Today lwtunnel_skb_lwstate is called from lwtunnel_output which is only
called from ipv4 code.
And my ipv6 variant code was supposed to have a 6 suffix. something like
lwtunnel_output6.
Or to be more explicit i will probably have variants of the output and
skb handling functions like,
lwtunnel_output_ipv4 and lwtunnel_output_ipv6.
>> +
>> + ret = -EOPNOTSUPP;
>> + nest = nla_nest_start(skb, RTA_ENCAP);
>
> Again, it doesn't look like this will build since RTA_ENCAP isn't
> added until patch 2.
>
ack, sorry abt the patch ordering. will fix it.
Thanks for the review.
next prev parent reply other threads:[~2015-06-19 15:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 4:49 [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels Roopa Prabhu
2015-06-19 14:43 ` Robert Shearman
2015-06-19 15:14 ` roopa [this message]
2015-06-19 17:25 ` Robert Shearman
2015-06-19 18:34 ` roopa
2015-06-19 18:39 ` Robert Shearman
2015-06-20 14:27 ` roopa
2015-06-21 20:40 ` Thomas Graf
2015-06-22 2:48 ` roopa
2015-06-20 16:38 ` Nikolay Aleksandrov
2015-06-22 2:05 ` roopa
2015-06-21 20:32 ` Thomas Graf
2015-06-22 2:47 ` roopa
2015-07-03 9:49 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558431C3.5020703@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rshearma@brocade$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox