From: roopa <roopa@cumulusnetworks•com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks•com>
Cc: ebiederm@xmission•com, rshearma@brocade•com, tgraf@suug•ch,
davem@davemloft•net, netdev@vger•kernel.org
Subject: Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels
Date: Sun, 21 Jun 2015 19:05:03 -0700 [thread overview]
Message-ID: <55876D4F.9030204@cumulusnetworks.com> (raw)
In-Reply-To: <B5595950-0AF1-4141-A7FA-2C0CB11950D3@cumulusnetworks.com>
On 6/20/15, 9:38 AM, Nikolay Aleksandrov wrote:
> <<<snip>>>
>> diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
>> new file mode 100644
>> index 0000000..29c7802
>> --- /dev/null
>> +++ b/net/core/lwtunnel.c
>> @@ -0,0 +1,162 @@
>> +/*
>> + * lwtunnel Infrastructure for light weight tunnels like mpls
>> + *
>> + *
>> + * This program is free software; you can redistribute it and/or
>> + * modify it under the terms of the GNU General Public License
>> + * as published by the Free Software Foundation; either version
>> + * 2 of the License, or (at your option) any later version.
>> + *
>> + */
>> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
>> +
>> +#include <linux/capability.h>
>> +#include <linux/module.h>
>> +#include <linux/types.h>
>> +#include <linux/kernel.h>
>> +#include <linux/slab.h>
>> +#include <linux/uaccess.h>
>> +#include <linux/skbuff.h>
>> +#include <linux/netdevice.h>
>> +#include <linux/in.h>
>> +#include <linux/init.h>
>> +#include <linux/err.h>
>> +
>> +#include <net/lwtunnel.h>
>> +#include <net/rtnetlink.h>
>> +
>> +struct lwtunnel_state *lwtunnel_state_alloc(int hdr_len)
>> +{
>> + struct lwtunnel_state *lws;
>> +
>> + return kzalloc(sizeof(*lws) + hdr_len, GFP_KERNEL);
> This seems to be called with rcu_read_lock so GFP_ATOMIC would have to
> be used. (Judging by patch 3/3’s mpls_build_state and lwtunnel_build_state)
>
yep, correct. thanks
next prev parent reply other threads:[~2015-06-22 2:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 4:49 [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels Roopa Prabhu
2015-06-19 14:43 ` Robert Shearman
2015-06-19 15:14 ` roopa
2015-06-19 17:25 ` Robert Shearman
2015-06-19 18:34 ` roopa
2015-06-19 18:39 ` Robert Shearman
2015-06-20 14:27 ` roopa
2015-06-21 20:40 ` Thomas Graf
2015-06-22 2:48 ` roopa
2015-06-20 16:38 ` Nikolay Aleksandrov
2015-06-22 2:05 ` roopa [this message]
2015-06-21 20:32 ` Thomas Graf
2015-06-22 2:47 ` roopa
2015-07-03 9:49 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55876D4F.9030204@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nikolay@cumulusnetworks$(echo .)com \
--cc=rshearma@brocade$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox