From: roopa <roopa@cumulusnetworks•com>
To: Thomas Graf <tgraf@suug•ch>
Cc: Robert Shearman <rshearma@brocade•com>,
ebiederm@xmission•com, davem@davemloft•net,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels
Date: Sun, 21 Jun 2015 19:48:49 -0700 [thread overview]
Message-ID: <55877791.1030500@cumulusnetworks.com> (raw)
In-Reply-To: <20150621204044.GD4228@pox.localdomain>
On 6/21/15, 1:40 PM, Thomas Graf wrote:
> On 06/20/15 at 07:27am, roopa wrote:
>> On 6/19/15, 11:39 AM, Robert Shearman wrote:
>>>
>>> Sorry for not being clear, but I meant that there would have to be
>>> lwtunnel_skb_lwstate functions for ipv4 and ipv6 to match the output
>>> functions. So in the vxlan use case where it's using a netdevice, how
>>> would it determine which one to call?
>> thanks for that clarification, and good point. I see some areas of the
>> kernel checking for skb->protocol to do the conversion (something like
>> below). I am guessing that is acceptable.
>> if (skb->protocol == htons(ETH_P_IPV6))
>> struct rt6_info *rt6 = (struct rt6_info *)skb_dst(skb);
> I'm not yet convinced that it makes sense to offer the no-netdevice
> shortcut for VXLAN. I'm not convinced we need yet another VXLAN data
> path. In fact, I'm trying to get rid of the OVS one for this specific
> reason.
>
> I have no objection though if somebody comes up with an architecture
> that can't just pass the required metadata between the namespaces and
> do the actual encapsulation in a single net_device in the root/host
> namespace.
>
> Either way, I thin it's fair to defer to this to a later point. We
> don't need to solve this for the first iteration of MPLS and VXLAN
> implementation.
ack, thanks for your thoughts on this.
next prev parent reply other threads:[~2015-06-22 2:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 4:49 [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels Roopa Prabhu
2015-06-19 14:43 ` Robert Shearman
2015-06-19 15:14 ` roopa
2015-06-19 17:25 ` Robert Shearman
2015-06-19 18:34 ` roopa
2015-06-19 18:39 ` Robert Shearman
2015-06-20 14:27 ` roopa
2015-06-21 20:40 ` Thomas Graf
2015-06-22 2:48 ` roopa [this message]
2015-06-20 16:38 ` Nikolay Aleksandrov
2015-06-22 2:05 ` roopa
2015-06-21 20:32 ` Thomas Graf
2015-06-22 2:47 ` roopa
2015-07-03 9:49 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55877791.1030500@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rshearma@brocade$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox