From: roopa <roopa@cumulusnetworks•com>
To: Robert Shearman <rshearma@brocade•com>
Cc: ebiederm@xmission•com, tgraf@suug•ch, davem@davemloft•net,
netdev@vger•kernel.org
Subject: Re: [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels
Date: Sat, 20 Jun 2015 07:27:25 -0700 [thread overview]
Message-ID: <5585784D.3020809@cumulusnetworks.com> (raw)
In-Reply-To: <558461CB.3020408@brocade.com>
On 6/19/15, 11:39 AM, Robert Shearman wrote:
> On 19/06/15 19:34, roopa wrote:
>> On 6/19/15, 10:25 AM, Robert Shearman wrote:
>>> n 19/06/15 16:14, roopa wrote:
>>>
>> In the netdevice case, this output function is not called atall. It
>> should just follow the existing netdevice the route is pointing to.
>
> Sorry for not being clear, but I meant that there would have to be
> lwtunnel_skb_lwstate functions for ipv4 and ipv6 to match the output
> functions. So in the vxlan use case where it's using a netdevice, how
> would it determine which one to call?
thanks for that clarification, and good point. I see some areas of the
kernel checking for skb->protocol to do the conversion (something like
below). I am guessing that is acceptable.
if (skb->protocol == htons(ETH_P_IPV6))
struct rt6_info *rt6 = (struct rt6_info *)skb_dst(skb);
next prev parent reply other threads:[~2015-06-20 14:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 4:49 [PATCH net-next RFC v2 1/3] lwt: infrastructure to support light weight tunnels Roopa Prabhu
2015-06-19 14:43 ` Robert Shearman
2015-06-19 15:14 ` roopa
2015-06-19 17:25 ` Robert Shearman
2015-06-19 18:34 ` roopa
2015-06-19 18:39 ` Robert Shearman
2015-06-20 14:27 ` roopa [this message]
2015-06-21 20:40 ` Thomas Graf
2015-06-22 2:48 ` roopa
2015-06-20 16:38 ` Nikolay Aleksandrov
2015-06-22 2:05 ` roopa
2015-06-21 20:32 ` Thomas Graf
2015-06-22 2:47 ` roopa
2015-07-03 9:49 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5585784D.3020809@cumulusnetworks.com \
--to=roopa@cumulusnetworks$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=ebiederm@xmission$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=rshearma@brocade$(echo .)com \
--cc=tgraf@suug$(echo .)ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox