public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: David Aguilar <davvid@gmail•com>
To: gitster@pobox•com, johan@herland•net
Cc: git@vger•kernel.org, barkalow@iabervon•org,
	Johannes.Schindelin@gmx•de, mhagger@alum•mit.edu,
	David Aguilar <davvid@gmail•com>
Subject: [PATCH 2/2] git_remote_cvs: Use $(shell) in the Makefile
Date: Sun, 16 Aug 2009 13:38:08 -0700	[thread overview]
Message-ID: <1250455088-23457-2-git-send-email-davvid@gmail.com> (raw)
In-Reply-To: <1250455088-23457-1-git-send-email-davvid@gmail.com>

This updates the git_remote_cvs Makefile to use the same
$(shell <cmd>) style used by the top-level git Makefile.

Signed-off-by: David Aguilar <davvid@gmail•com>
---
 git_remote_cvs/Makefile |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/git_remote_cvs/Makefile b/git_remote_cvs/Makefile
index f52c096..d281d48 100644
--- a/git_remote_cvs/Makefile
+++ b/git_remote_cvs/Makefile
@@ -23,10 +23,13 @@ ifndef V
 	QUIETSETUP = --quiet
 endif
 
-PYLIBDIR=`$(PYTHON_PATH) -c "import sys; print 'lib/python%i.%i/site-packages' % sys.version_info[:2]"`
+PYLIBDIR=$(shell $(PYTHON_PATH) -c \
+	 "import sys; \
+	 print 'lib/python%i.%i/site-packages' % sys.version_info[:2]")
 
 all: $(pysetupfile)
 	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) build
+
 install: $(pysetupfile)
 	$(PYTHON_PATH) $(pysetupfile) install \
 		--prefix $(prefix) \
@@ -34,6 +37,7 @@ install: $(pysetupfile)
 
 instlibdir: $(pysetupfile)
 	@echo "$(prefix)/$(PYLIBDIR)"
+
 clean:
 	$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a
 	$(RM) *.pyo *.pyc
-- 
1.6.4.169.g64d5

  reply	other threads:[~2009-08-16 20:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-12  0:13 [RFCv3 0/4] CVS remote helper Johan Herland
2009-08-12  0:13 ` [RFCv3 1/4] Basic build infrastructure for Python scripts Johan Herland
2009-08-12  0:13 ` [RFCv3 2/4] Add Python support library for CVS remote helper Johan Herland
2009-08-12  2:10   ` David Aguilar
2009-08-12  9:08     ` Johan Herland
2009-08-12 17:43       ` Sverre Rabbelier
2009-08-13  0:00       ` Michael Haggerty
2009-08-13  0:20         ` Johan Herland
2009-08-13  0:55     ` Junio C Hamano
2009-08-13  1:27       ` Johan Herland
2009-08-16 19:48   ` Junio C Hamano
2009-08-16 20:38     ` [PATCH 1/2] git_remote_cvs: Honor DESTDIR in the Makefile David Aguilar
2009-08-16 20:38       ` David Aguilar [this message]
2009-08-16 20:47         ` [PATCH 2/2] git_remote_cvs: Use $(shell) " David Aguilar
2009-08-16 20:55       ` [PATCH 1/2] git_remote_cvs: Honor DESTDIR " Johannes Schindelin
2009-08-16 21:03         ` David Aguilar
2009-08-16 21:21           ` Johannes Schindelin
2009-08-17  1:58           ` Johan Herland
2009-08-16 21:25         ` [PATCH v2 " David Aguilar
2009-08-16 21:25           ` [PATCH v2 2/2] git_remote_cvs: Use $(shell) " David Aguilar
2009-08-12  0:13 ` [RFCv3 3/4] Third draft of CVS remote helper program Johan Herland
2009-08-12  0:13 ` [RFCv3 4/4] Add simple selftests of git-remote-cvs functionality Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1250455088-23457-2-git-send-email-davvid@gmail.com \
    --to=davvid@gmail$(echo .)com \
    --cc=Johannes.Schindelin@gmx$(echo .)de \
    --cc=barkalow@iabervon$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=johan@herland$(echo .)net \
    --cc=mhagger@alum$(echo .)mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox