From: Johan Herland <johan@herland•net>
To: David Aguilar <davvid@gmail•com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx•de>,
gitster@pobox•com, git@vger•kernel.org, barkalow@iabervon•org,
mhagger@alum•mit.edu
Subject: Re: [PATCH 1/2] git_remote_cvs: Honor DESTDIR in the Makefile
Date: Mon, 17 Aug 2009 03:58:30 +0200 [thread overview]
Message-ID: <200908170358.30347.johan@herland.net> (raw)
In-Reply-To: <20090816210300.GB23522@gmail.com>
On Sunday 16 August 2009, David Aguilar wrote:
> I'll see if we rework this so that we end up passing "" to
> --root instead of /. I'm going to be gone for a few hours so
> probably won't be able to try it out until tonight.
Thanks a lot for your work! I will send an updated series shortly which will
include v2 of your DESTDIR/Makefile fixes, and also the fixes you suggested
earlier (including _lots_ of PEP8 fixes).
> Another thing to consider --
>
> Debian once submitted a bug against another Python app asking
> that we not place modules in site-packages unless we
> plan on having other applications importing those modules.
>
> The more appropriate place for them if we don't plan on that is
> $(prefix)/share/git-core/git_remote_cvs or something like that.
>
> I guess that's another thing to think about.
Yes, Debian raises a valid point. I haven't thought much about making the
git_remote_cvs package into something that would be useful for other
applications. (I just assumed that the Python convention was to install it
into site-packages regardless...) For now, I'll concentrate on git-remote-
cvs, and leave it to others to figure out if anything in the git_remote_cvs
package is useful for other programs.
Note that there's a small chicken-and-egg problem here as well: If Debian
refuses us to install into site-packages, it will be harder for other Python
programs to discover (and import) the git_remote_cvs package.
BTW, when we're on the subject of packaging: There are some variables in
git_remote_cvs/setup.py where I'm not sure what the correct value should be:
- version - should this follow Git's version number, or is it independent?
- author (and author_email + url) - For now, I'm referring to the Git
community. Should this be more specific/
Feedback welcome.
Have fun! :)
...Johan
--
Johan Herland, <johan@herland•net>
www.herland.net
next prev parent reply other threads:[~2009-08-17 1:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 0:13 [RFCv3 0/4] CVS remote helper Johan Herland
2009-08-12 0:13 ` [RFCv3 1/4] Basic build infrastructure for Python scripts Johan Herland
2009-08-12 0:13 ` [RFCv3 2/4] Add Python support library for CVS remote helper Johan Herland
2009-08-12 2:10 ` David Aguilar
2009-08-12 9:08 ` Johan Herland
2009-08-12 17:43 ` Sverre Rabbelier
2009-08-13 0:00 ` Michael Haggerty
2009-08-13 0:20 ` Johan Herland
2009-08-13 0:55 ` Junio C Hamano
2009-08-13 1:27 ` Johan Herland
2009-08-16 19:48 ` Junio C Hamano
2009-08-16 20:38 ` [PATCH 1/2] git_remote_cvs: Honor DESTDIR in the Makefile David Aguilar
2009-08-16 20:38 ` [PATCH 2/2] git_remote_cvs: Use $(shell) " David Aguilar
2009-08-16 20:47 ` David Aguilar
2009-08-16 20:55 ` [PATCH 1/2] git_remote_cvs: Honor DESTDIR " Johannes Schindelin
2009-08-16 21:03 ` David Aguilar
2009-08-16 21:21 ` Johannes Schindelin
2009-08-17 1:58 ` Johan Herland [this message]
2009-08-16 21:25 ` [PATCH v2 " David Aguilar
2009-08-16 21:25 ` [PATCH v2 2/2] git_remote_cvs: Use $(shell) " David Aguilar
2009-08-12 0:13 ` [RFCv3 3/4] Third draft of CVS remote helper program Johan Herland
2009-08-12 0:13 ` [RFCv3 4/4] Add simple selftests of git-remote-cvs functionality Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908170358.30347.johan@herland.net \
--to=johan@herland$(echo .)net \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=barkalow@iabervon$(echo .)org \
--cc=davvid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mhagger@alum$(echo .)mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox