From: David Aguilar <davvid@gmail•com>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: gitster@pobox•com, johan@herland•net, git@vger•kernel.org,
barkalow@iabervon•org, mhagger@alum•mit.edu
Subject: Re: [PATCH 1/2] git_remote_cvs: Honor DESTDIR in the Makefile
Date: Sun, 16 Aug 2009 14:03:01 -0700 [thread overview]
Message-ID: <20090816210300.GB23522@gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0908162251360.8306@pacific.mpi-cbg.de>
On Sun, Aug 16, 2009 at 10:55:29PM +0200, Johannes Schindelin wrote:
> Hi,
>
> On Sun, 16 Aug 2009, David Aguilar wrote:
>
> > diff --git a/git_remote_cvs/Makefile b/git_remote_cvs/Makefile
> > index 8dbf3fa..f52c096 100644
> > --- a/git_remote_cvs/Makefile
> > +++ b/git_remote_cvs/Makefile
> > @@ -3,6 +3,15 @@
> > #
> > pysetupfile:=setup.py
> >
> > +# Setup the DESTDIR for Python.
> > +ifeq ($(DESTDIR),)
> > +PYTHON_DESTDIR = /
>
> Hmm. I think this would break on msysGit. Not that anybody worked on
> getting Python to compile on msysGit.
>
> (Just to make sure you understand the issue: on msysGit, we set prefix to
> "" (and I think DESTDIR somehow ends up taking on the same value). Now,
> when DESTDIR is set to "/" and something wants to be copied to
> $(DESTDIR)/something, the latter expands to //something, which tells MSys
> not to expand //something to the correct Windows path.
I see. Hmm.. setup.py is a real pain.
I'll see if we rework this so that we end up passing "" to
--root instead of /. I'm going to be gone for a few hours so
probably won't be able to try it out until tonight.
Another thing to consider --
Debian once submitted a bug against another Python app asking
that we not place modules in site-packages unless we
plan on having other applications importing those modules.
The more appropriate place for them if we don't plan on that is
$(prefix)/share/git-core/git_remote_cvs or something like that.
I guess that's another thing to think about.
--
David
next prev parent reply other threads:[~2009-08-16 21:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 0:13 [RFCv3 0/4] CVS remote helper Johan Herland
2009-08-12 0:13 ` [RFCv3 1/4] Basic build infrastructure for Python scripts Johan Herland
2009-08-12 0:13 ` [RFCv3 2/4] Add Python support library for CVS remote helper Johan Herland
2009-08-12 2:10 ` David Aguilar
2009-08-12 9:08 ` Johan Herland
2009-08-12 17:43 ` Sverre Rabbelier
2009-08-13 0:00 ` Michael Haggerty
2009-08-13 0:20 ` Johan Herland
2009-08-13 0:55 ` Junio C Hamano
2009-08-13 1:27 ` Johan Herland
2009-08-16 19:48 ` Junio C Hamano
2009-08-16 20:38 ` [PATCH 1/2] git_remote_cvs: Honor DESTDIR in the Makefile David Aguilar
2009-08-16 20:38 ` [PATCH 2/2] git_remote_cvs: Use $(shell) " David Aguilar
2009-08-16 20:47 ` David Aguilar
2009-08-16 20:55 ` [PATCH 1/2] git_remote_cvs: Honor DESTDIR " Johannes Schindelin
2009-08-16 21:03 ` David Aguilar [this message]
2009-08-16 21:21 ` Johannes Schindelin
2009-08-17 1:58 ` Johan Herland
2009-08-16 21:25 ` [PATCH v2 " David Aguilar
2009-08-16 21:25 ` [PATCH v2 2/2] git_remote_cvs: Use $(shell) " David Aguilar
2009-08-12 0:13 ` [RFCv3 3/4] Third draft of CVS remote helper program Johan Herland
2009-08-12 0:13 ` [RFCv3 4/4] Add simple selftests of git-remote-cvs functionality Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090816210300.GB23522@gmail.com \
--to=davvid@gmail$(echo .)com \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=barkalow@iabervon$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=johan@herland$(echo .)net \
--cc=mhagger@alum$(echo .)mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox