From: Johan Herland <johan@herland•net>
To: Michael Haggerty <mhagger@alum•mit.edu>
Cc: David Aguilar <davvid@gmail•com>,
git@vger•kernel.org, barkalow@iabervon•org, gitster@pobox•com,
Johannes.Schindelin@gmx•de,
Sverre Rabbelier <srabbelier@gmail•com>
Subject: Re: [RFCv3 2/4] Add Python support library for CVS remote helper
Date: Thu, 13 Aug 2009 02:20:02 +0200 [thread overview]
Message-ID: <200908130220.02517.johan@herland.net> (raw)
In-Reply-To: <4A83579E.70302@alum.mit.edu>
On Thursday 13 August 2009, Michael Haggerty wrote:
> Johan Herland wrote:
> > On Wednesday 12 August 2009, David Aguilar wrote:
> >> On Wed, Aug 12, 2009 at 02:13:49AM +0200, Johan Herland wrote:
> >>> + def __init__ (self, date, author, message):
> >>> + self.revs = {} # dict: path -> CvsRev object
> >>> + self.date = date # CvsDate object
> >>> + self.author = author
> >>> + self.message = message # Lines of commit message
> >>
> >> pep8 and other parts of the git codebase recommend against
> >> lining up the equals signs like that. Ya, sorry for the nits
> >> being that they're purely stylistic.
> >
> > I can't find a good rationale for this rule in PEP8 (other than Guido's
> > personal style), and I personally find the above much more readable
> > (otherwise I wouldn't go through the trouble of lining them all up...).
> > Can I claim exception (1) (readability)?
>
> I think you are missing the point. It may be true that the rules in
> PEP8 were *originally* written according to the unjustified whims of the
> BDFL, but now that they are established the reason for following them is
> not that Guido likes them but rather to be consistent with the bulk of
> other Python code on the planet.
Ok. I will try to follow PEP8 as closely as possible.
> With respect to the rule to use 4-space indents, there are serious
> practical problems with using tabs *in addition to* the consistency
> argument.
There are? What arguments? Assuming I don't mix spaces and tabs (which I
certainly don't), I can't see any "practical problems" with using tabs
(except for the PEP8/consistency issue).
...Johan
--
Johan Herland, <johan@herland•net>
www.herland.net
next prev parent reply other threads:[~2009-08-13 0:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 0:13 [RFCv3 0/4] CVS remote helper Johan Herland
2009-08-12 0:13 ` [RFCv3 1/4] Basic build infrastructure for Python scripts Johan Herland
2009-08-12 0:13 ` [RFCv3 2/4] Add Python support library for CVS remote helper Johan Herland
2009-08-12 2:10 ` David Aguilar
2009-08-12 9:08 ` Johan Herland
2009-08-12 17:43 ` Sverre Rabbelier
2009-08-13 0:00 ` Michael Haggerty
2009-08-13 0:20 ` Johan Herland [this message]
2009-08-13 0:55 ` Junio C Hamano
2009-08-13 1:27 ` Johan Herland
2009-08-16 19:48 ` Junio C Hamano
2009-08-16 20:38 ` [PATCH 1/2] git_remote_cvs: Honor DESTDIR in the Makefile David Aguilar
2009-08-16 20:38 ` [PATCH 2/2] git_remote_cvs: Use $(shell) " David Aguilar
2009-08-16 20:47 ` David Aguilar
2009-08-16 20:55 ` [PATCH 1/2] git_remote_cvs: Honor DESTDIR " Johannes Schindelin
2009-08-16 21:03 ` David Aguilar
2009-08-16 21:21 ` Johannes Schindelin
2009-08-17 1:58 ` Johan Herland
2009-08-16 21:25 ` [PATCH v2 " David Aguilar
2009-08-16 21:25 ` [PATCH v2 2/2] git_remote_cvs: Use $(shell) " David Aguilar
2009-08-12 0:13 ` [RFCv3 3/4] Third draft of CVS remote helper program Johan Herland
2009-08-12 0:13 ` [RFCv3 4/4] Add simple selftests of git-remote-cvs functionality Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908130220.02517.johan@herland.net \
--to=johan@herland$(echo .)net \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=barkalow@iabervon$(echo .)org \
--cc=davvid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=srabbelier@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox