From: Johan Herland <johan@herland•net>
To: Junio C Hamano <gitster@pobox•com>
Cc: David Aguilar <davvid@gmail•com>,
git@vger•kernel.org, barkalow@iabervon•org,
Johannes.Schindelin@gmx•de
Subject: Re: [RFCv3 2/4] Add Python support library for CVS remote helper
Date: Thu, 13 Aug 2009 03:27:28 +0200 [thread overview]
Message-ID: <200908130327.28571.johan@herland.net> (raw)
In-Reply-To: <7vzla4r0qc.fsf@alter.siamese.dyndns.org>
On Thursday 13 August 2009, Junio C Hamano wrote:
> David Aguilar <davvid@gmail•com> writes:
> > This also had me wondering about the following:
> > git uses tabs for indentation
>
> Not relevant. That is a rule for our "C" source code. We also use it in
> our Perl scripts and shell scripts because there is no single "one right
> way" that is strongly defined and everybody adheres to, like the 4-space
> rule Python folks have.
>
> > BUT, the python convention is to use 4-space indents ala PEP-8
> > http://www.python.org/dev/peps/pep-0008/
> >
> > It might be appealing to when-in-Rome (Rome being Python) here
> > and do things the python way when we code in Python.
>
> Yes, this is more important.
>
> >> + if len(msg) > 25: msg = msg[:22] + "..." # Max 25 chars long
> >> + return "<Changeset @(%s) by %s (%s) updating %i files>" % (
> >> + self.date, self.author, msg, len(self.revs))
> >
> > Similar to the git coding style, this might be better written:
>
> So is this one. If experienced Python folks also frown on single-line
> conditionals, then by all means please update this. But if this
> suggestion is solely because we don't do a single-line conditional in our
> C source code, then please do not insist on it too strongly. The code
> should look familiar to Pythonistas with good tastes (if such a class of
> people exist, that is ;-)).
Ok. Thanks. I will follow PEP8 as closely as possible, including the 4-space
indent.
...Johan
--
Johan Herland, <johan@herland•net>
www.herland.net
next prev parent reply other threads:[~2009-08-13 1:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 0:13 [RFCv3 0/4] CVS remote helper Johan Herland
2009-08-12 0:13 ` [RFCv3 1/4] Basic build infrastructure for Python scripts Johan Herland
2009-08-12 0:13 ` [RFCv3 2/4] Add Python support library for CVS remote helper Johan Herland
2009-08-12 2:10 ` David Aguilar
2009-08-12 9:08 ` Johan Herland
2009-08-12 17:43 ` Sverre Rabbelier
2009-08-13 0:00 ` Michael Haggerty
2009-08-13 0:20 ` Johan Herland
2009-08-13 0:55 ` Junio C Hamano
2009-08-13 1:27 ` Johan Herland [this message]
2009-08-16 19:48 ` Junio C Hamano
2009-08-16 20:38 ` [PATCH 1/2] git_remote_cvs: Honor DESTDIR in the Makefile David Aguilar
2009-08-16 20:38 ` [PATCH 2/2] git_remote_cvs: Use $(shell) " David Aguilar
2009-08-16 20:47 ` David Aguilar
2009-08-16 20:55 ` [PATCH 1/2] git_remote_cvs: Honor DESTDIR " Johannes Schindelin
2009-08-16 21:03 ` David Aguilar
2009-08-16 21:21 ` Johannes Schindelin
2009-08-17 1:58 ` Johan Herland
2009-08-16 21:25 ` [PATCH v2 " David Aguilar
2009-08-16 21:25 ` [PATCH v2 2/2] git_remote_cvs: Use $(shell) " David Aguilar
2009-08-12 0:13 ` [RFCv3 3/4] Third draft of CVS remote helper program Johan Herland
2009-08-12 0:13 ` [RFCv3 4/4] Add simple selftests of git-remote-cvs functionality Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908130327.28571.johan@herland.net \
--to=johan@herland$(echo .)net \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=barkalow@iabervon$(echo .)org \
--cc=davvid@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox