From: Demi Marie Obenour <demiobenour@gmail•com>
To: Kuldeep Singh <kuldeep.singh@oss•qualcomm.com>,
Eric Biggers <ebiggers@kernel•org>,
Krzysztof Kozlowski <krzk@kernel•org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss•qualcomm.com>,
Herbert Xu <herbert@gondor•apana.org.au>,
"David S. Miller" <davem@davemloft•net>,
Thara Gopinath <thara.gopinath@gmail•com>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Russell King <linux@armlinux•org.uk>,
linux-kernel@vger•kernel.org, linux-crypto@vger•kernel.org,
linux-arm-msm@vger•kernel.org, Ard Biesheuvel <ardb@kernel•org>,
devicetree@vger•kernel.org, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
Date: Mon, 25 May 2026 03:49:30 -0400 [thread overview]
Message-ID: <71bdcbc6-9cea-465b-9fb6-83084733261f@gmail.com> (raw)
In-Reply-To: <e36172c6-4424-4b77-9b3c-47dcdbdff05b@oss.qualcomm.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 1441 bytes --]
On 5/25/26 02:29, Kuldeep Singh wrote:
>> This driver is more than an order of magnitude slower than the CPU for
>> both encryption and hashing. See:
>>
>> https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/
>> https://lore.kernel.org/r/20250615031807.GA81869@sol/
>>
>> There are many examples of it having bugs as well, for example see the
>> second link above.
>>
>> That's why it had to be disabled via the cra_priority system. This
>> driver was actively making Linux worse.
>>
>> This isn't particularly unique to drivers/crypto/, of course. This one
>> we just have data on, so it's a bit clearer.
>>
>> I've yet to see any real reason to keep this driver.
>
> https://lore.kernel.org/all/c1697372-54ec-4f57-85d9-ad375ff1a44d@oss.qualcomm.com/
> Kindly check my latest reply to the thread. There are numerous usecases
> like DRM(Digital rights management) coming up and qce driver is required
> for secure content.
1. This content is restricted. It's no more secure.
2. General purpose (desktop, laptop) systems won't be able to display
restricted content. To the best of my knowledge, the only Wayland
compositors that support restricted content are Weston and Chromium
OS's compositor.
3. Will this code be useful without out of tree drivers?
4. Does this use the existing crypto APIs or a separate API?
--
Sincerely,
Demi Marie Obenour (she/her/hers)
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-05-25 7:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 19:03 [PATCH 0/2] Delete the Qualcomm crypto engine Demi Marie Obenour via B4 Relay
2026-05-23 19:03 ` [PATCH 2/2] devicetree: Mark QCE bindings as deprecated Demi Marie Obenour via B4 Relay
[not found] ` <20260523-delete-qce-v1-1-86105cd7f406@gmail.com>
2026-05-24 16:42 ` [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver Dmitry Baryshkov
2026-05-24 20:12 ` Demi Marie Obenour
2026-05-24 20:29 ` Krzysztof Kozlowski
2026-05-24 20:31 ` Demi Marie Obenour
2026-05-24 20:45 ` Eric Biggers
2026-05-25 6:29 ` Kuldeep Singh
2026-05-25 7:49 ` Demi Marie Obenour [this message]
2026-05-25 8:11 ` Dmitry Baryshkov
2026-05-25 11:10 ` Kuldeep Singh
2026-05-30 10:48 ` Krzysztof Kozlowski
2026-05-24 20:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71bdcbc6-9cea-465b-9fb6-83084733261f@gmail.com \
--to=demiobenour@gmail$(echo .)com \
--cc=andersson@kernel$(echo .)org \
--cc=ardb@kernel$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.baryshkov@oss$(echo .)qualcomm.com \
--cc=ebiggers@kernel$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=kuldeep.singh@oss$(echo .)qualcomm.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=robh@kernel$(echo .)org \
--cc=thara.gopinath@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox