From: Krzysztof Kozlowski <krzk@kernel•org>
To: Demi Marie Obenour <demiobenour@gmail•com>,
Dmitry Baryshkov <dmitry.baryshkov@oss•qualcomm.com>
Cc: Herbert Xu <herbert@gondor•apana.org.au>,
"David S. Miller" <davem@davemloft•net>,
Thara Gopinath <thara.gopinath@gmail•com>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Russell King <linux@armlinux•org.uk>,
linux-kernel@vger•kernel.org, linux-crypto@vger•kernel.org,
linux-arm-msm@vger•kernel.org, Eric Biggers <ebiggers@kernel•org>,
Ard Biesheuvel <ardb@kernel•org>,
devicetree@vger•kernel.org, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
Date: Sun, 24 May 2026 22:29:28 +0200 [thread overview]
Message-ID: <d97382a6-6c5d-4a3f-89cc-3ae9b432de3f@kernel.org> (raw)
In-Reply-To: <66317f6a-645e-432b-ae11-8f40569d4117@gmail.com>
On 24/05/2026 22:12, Demi Marie Obenour wrote:
> On 5/24/26 12:42, Dmitry Baryshkov wrote:
>> On Sat, May 23, 2026 at 03:03:56PM -0400, Demi Marie Obenour via B4 Relay wrote:
>>> From: Demi Marie Obenour <demiobenour@gmail•com>
>>>
>>> It's slower than the generic C code and causes problems.
>>
>> Which problems?
>
> See https://lore.kernel.org/all/20260522024912.GC5937@quark/.
Your commit is still incomplete and other people's opinion is poor
reason. If you do not know what to write, ask that person to make
necessary changes.
Not mentioning that removing driver is not even necessary to achieve the
goal Eric was mentioning and if I understood correctly: you are removing
even the pieces Eric found useful.
>
> Also, if there are no systems in which the QCE driver is actually
> the highest priority, then unless someone adjusts priorities manually
> it's unused code.
That's not a reason to remove a driver.
>
>> Also in the security world faster and safer are two orthogonal axis with
>> very limited correlation.
>
> If by "safer" you mean protection against physical side-channel
> attacks, then my understanding is that all operations on secret keys
> need to be masked. This includes copying and storage.
>
> Linux only supports this for protected keys, and even then sometimes
> uses the kernel's own RNG for key generation. There is no support
> for using the QCE for protected keys.
>
> Linux does support using hardware-wrapped keys with inline crypto
> engines, which are what are actually used on Android.
Patches are discussed for some time, did you miss that?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-05-24 20:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 19:03 [PATCH 0/2] Delete the Qualcomm crypto engine Demi Marie Obenour via B4 Relay
2026-05-23 19:03 ` [PATCH 2/2] devicetree: Mark QCE bindings as deprecated Demi Marie Obenour via B4 Relay
[not found] ` <20260523-delete-qce-v1-1-86105cd7f406@gmail.com>
2026-05-24 16:42 ` [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver Dmitry Baryshkov
2026-05-24 20:12 ` Demi Marie Obenour
2026-05-24 20:29 ` Krzysztof Kozlowski [this message]
2026-05-24 20:31 ` Demi Marie Obenour
2026-05-24 20:45 ` Eric Biggers
2026-05-25 6:29 ` Kuldeep Singh
2026-05-25 7:49 ` Demi Marie Obenour
2026-05-25 8:11 ` Dmitry Baryshkov
2026-05-25 11:10 ` Kuldeep Singh
2026-05-30 10:48 ` Krzysztof Kozlowski
2026-05-24 20:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d97382a6-6c5d-4a3f-89cc-3ae9b432de3f@kernel.org \
--to=krzk@kernel$(echo .)org \
--cc=andersson@kernel$(echo .)org \
--cc=ardb@kernel$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=demiobenour@gmail$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.baryshkov@oss$(echo .)qualcomm.com \
--cc=ebiggers@kernel$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=robh@kernel$(echo .)org \
--cc=thara.gopinath@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox