From: Kuldeep Singh <kuldeep.singh@oss•qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss•qualcomm.com>
Cc: Eric Biggers <ebiggers@kernel•org>,
Krzysztof Kozlowski <krzk@kernel•org>,
Demi Marie Obenour <demiobenour@gmail•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
"David S. Miller" <davem@davemloft•net>,
Thara Gopinath <thara.gopinath@gmail•com>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Russell King <linux@armlinux•org.uk>,
linux-kernel@vger•kernel.org, linux-crypto@vger•kernel.org,
linux-arm-msm@vger•kernel.org, Ard Biesheuvel <ardb@kernel•org>,
devicetree@vger•kernel.org, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
Date: Mon, 25 May 2026 16:40:51 +0530 [thread overview]
Message-ID: <ba038bf4-d1bc-4e20-b4a7-ad24de760962@oss.qualcomm.com> (raw)
In-Reply-To: <rb35vwvusd733s2zbgsitof3cpoyyfope4cpeh47xldw27ufix@7fm6bgr4wtkz>
On 25-05-2026 13:41, Dmitry Baryshkov wrote:
> On Mon, May 25, 2026 at 11:59:33AM +0530, Kuldeep Singh wrote:
>>> This driver is more than an order of magnitude slower than the CPU for
>>> both encryption and hashing. See:
>>>
>>> https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/
>>> https://lore.kernel.org/r/20250615031807.GA81869@sol/
>>>
>>> There are many examples of it having bugs as well, for example see the
>>> second link above.
>>>
>>> That's why it had to be disabled via the cra_priority system. This
>>> driver was actively making Linux worse.
>>>
>>> This isn't particularly unique to drivers/crypto/, of course. This one
>>> we just have data on, so it's a bit clearer.
>>>
>>> I've yet to see any real reason to keep this driver.
>>
>> https://lore.kernel.org/all/c1697372-54ec-4f57-85d9-ad375ff1a44d@oss.qualcomm.com/
>> Kindly check my latest reply to the thread. There are numerous usecases
>> like DRM(Digital rights management) coming up and qce driver is required
>> for secure content.
>>
>>> Crypto drivers need to be held to a higher standard than other device
>>> drivers, as well. The onus is on those who want to keep a particular
>>> crypto driver to prove that it's worth keeping.
>> Sure, I'll be working on stabilizing self_tests infra for qce.
>> Kindly allow sometime to go over failures in crypto selftest and will
>> submit fix if applicable.
>
> Why are not selftests a part of your default config? How are you testing
> the driver?
We are validating the driver probe and kcapi userspace tests while
validating qce algos. Locally we update all 3 algo priority and then run
kcapi_convinience.sh test suite to ensure it picks qce algos.
Please note, previously were not aware need to run selftests suite too.
Got to know about this once issue was reported.
>
>> So far, i am observing 2 ciphers failing(xts-aes-qce and ctr-aes-qce )
>> with CONFIG_CRYPTO_SELFTESTS enabled.
>
> Please make sure to run the tests on older platforms too, not just the
> latest & greatest.
Yes, will check on all the platforms.
--
Regards
Kuldeep
next prev parent reply other threads:[~2026-05-25 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 19:03 [PATCH 0/2] Delete the Qualcomm crypto engine Demi Marie Obenour via B4 Relay
2026-05-23 19:03 ` [PATCH 2/2] devicetree: Mark QCE bindings as deprecated Demi Marie Obenour via B4 Relay
[not found] ` <20260523-delete-qce-v1-1-86105cd7f406@gmail.com>
2026-05-24 16:42 ` [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver Dmitry Baryshkov
2026-05-24 20:12 ` Demi Marie Obenour
2026-05-24 20:29 ` Krzysztof Kozlowski
2026-05-24 20:31 ` Demi Marie Obenour
2026-05-24 20:45 ` Eric Biggers
2026-05-25 6:29 ` Kuldeep Singh
2026-05-25 7:49 ` Demi Marie Obenour
2026-05-25 8:11 ` Dmitry Baryshkov
2026-05-25 11:10 ` Kuldeep Singh [this message]
2026-05-30 10:48 ` Krzysztof Kozlowski
2026-05-24 20:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba038bf4-d1bc-4e20-b4a7-ad24de760962@oss.qualcomm.com \
--to=kuldeep.singh@oss$(echo .)qualcomm.com \
--cc=andersson@kernel$(echo .)org \
--cc=ardb@kernel$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=demiobenour@gmail$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.baryshkov@oss$(echo .)qualcomm.com \
--cc=ebiggers@kernel$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=robh@kernel$(echo .)org \
--cc=thara.gopinath@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox