From: Eric Biggers <ebiggers@kernel•org>
To: Krzysztof Kozlowski <krzk@kernel•org>
Cc: Demi Marie Obenour <demiobenour@gmail•com>,
Dmitry Baryshkov <dmitry.baryshkov@oss•qualcomm.com>,
Herbert Xu <herbert@gondor•apana.org.au>,
"David S. Miller" <davem@davemloft•net>,
Thara Gopinath <thara.gopinath@gmail•com>,
Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Bjorn Andersson <andersson@kernel•org>,
Konrad Dybcio <konradybcio@kernel•org>,
Russell King <linux@armlinux•org.uk>,
linux-kernel@vger•kernel.org, linux-crypto@vger•kernel.org,
linux-arm-msm@vger•kernel.org, Ard Biesheuvel <ardb@kernel•org>,
devicetree@vger•kernel.org, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
Date: Sun, 24 May 2026 15:45:37 -0500 [thread overview]
Message-ID: <20260524204537.GB110177@quark> (raw)
In-Reply-To: <d97382a6-6c5d-4a3f-89cc-3ae9b432de3f@kernel.org>
On Sun, May 24, 2026 at 10:29:28PM +0200, Krzysztof Kozlowski wrote:
> On 24/05/2026 22:12, Demi Marie Obenour wrote:
> > On 5/24/26 12:42, Dmitry Baryshkov wrote:
> >> On Sat, May 23, 2026 at 03:03:56PM -0400, Demi Marie Obenour via B4 Relay wrote:
> >>> From: Demi Marie Obenour <demiobenour@gmail•com>
> >>>
> >>> It's slower than the generic C code and causes problems.
> >>
> >> Which problems?
> >
> > See https://lore.kernel.org/all/20260522024912.GC5937@quark/.
>
> Your commit is still incomplete and other people's opinion is poor
> reason. If you do not know what to write, ask that person to make
> necessary changes.
>
> Not mentioning that removing driver is not even necessary to achieve the
> goal Eric was mentioning and if I understood correctly: you are removing
> even the pieces Eric found useful.
This driver is more than an order of magnitude slower than the CPU for
both encryption and hashing. See:
https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/
https://lore.kernel.org/r/20250615031807.GA81869@sol/
There are many examples of it having bugs as well, for example see the
second link above.
That's why it had to be disabled via the cra_priority system. This
driver was actively making Linux worse.
This isn't particularly unique to drivers/crypto/, of course. This one
we just have data on, so it's a bit clearer.
I've yet to see any real reason to keep this driver.
Crypto drivers need to be held to a higher standard than other device
drivers, as well. The onus is on those who want to keep a particular
crypto driver to prove that it's worth keeping.
- Eric
next prev parent reply other threads:[~2026-05-24 20:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 19:03 [PATCH 0/2] Delete the Qualcomm crypto engine Demi Marie Obenour via B4 Relay
2026-05-23 19:03 ` [PATCH 2/2] devicetree: Mark QCE bindings as deprecated Demi Marie Obenour via B4 Relay
[not found] ` <20260523-delete-qce-v1-1-86105cd7f406@gmail.com>
2026-05-24 16:42 ` [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver Dmitry Baryshkov
2026-05-24 20:12 ` Demi Marie Obenour
2026-05-24 20:29 ` Krzysztof Kozlowski
2026-05-24 20:31 ` Demi Marie Obenour
2026-05-24 20:45 ` Eric Biggers [this message]
2026-05-25 6:29 ` Kuldeep Singh
2026-05-25 7:49 ` Demi Marie Obenour
2026-05-25 8:11 ` Dmitry Baryshkov
2026-05-25 11:10 ` Kuldeep Singh
2026-05-30 10:48 ` Krzysztof Kozlowski
2026-05-24 20:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260524204537.GB110177@quark \
--to=ebiggers@kernel$(echo .)org \
--cc=andersson@kernel$(echo .)org \
--cc=ardb@kernel$(echo .)org \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=demiobenour@gmail$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.baryshkov@oss$(echo .)qualcomm.com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=konradybcio@kernel$(echo .)org \
--cc=krzk+dt@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=robh@kernel$(echo .)org \
--cc=thara.gopinath@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox