* [PATCH 0/2] Delete the Qualcomm crypto engine
@ 2026-05-23 19:03 Demi Marie Obenour via B4 Relay
2026-05-23 19:03 ` [PATCH 2/2] devicetree: Mark QCE bindings as deprecated Demi Marie Obenour via B4 Relay
[not found] ` <20260523-delete-qce-v1-1-86105cd7f406@gmail.com>
0 siblings, 2 replies; 13+ messages in thread
From: Demi Marie Obenour via B4 Relay @ 2026-05-23 19:03 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Thara Gopinath, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Russell King
Cc: linux-kernel, linux-crypto, linux-arm-msm, Eric Biggers,
Ard Biesheuvel, devicetree, linux-arm-kernel, Demi Marie Obenour
The only realistic uses I can think of are:
1. Very weak devices where QCE is actually faster.
2. Devices without bitsliced NEON.
Do any such devices exist in the wild? I have no idea.
Not even compile-tested, but should be trivial as it just deletes code.
I didn't change the device tree beyond marking the bindings as
deprecated.
Signed-off-by: Demi Marie Obenour <demiobenour@gmail•com>
---
Demi Marie Obenour (2):
crypto: Delete Qualcomm crypto engine driver
devicetree: Mark QCE bindings as deprecated
.../devicetree/bindings/crypto/qcom-qce.yaml | 3 +
MAINTAINERS | 8 -
arch/arm/configs/multi_v7_defconfig | 1 -
arch/arm64/configs/defconfig | 1 -
drivers/crypto/Kconfig | 111 ---
drivers/crypto/Makefile | 1 -
drivers/crypto/qce/Makefile | 9 -
drivers/crypto/qce/aead.c | 841 ---------------------
drivers/crypto/qce/aead.h | 56 --
drivers/crypto/qce/cipher.h | 56 --
drivers/crypto/qce/common.c | 595 ---------------
drivers/crypto/qce/common.h | 104 ---
drivers/crypto/qce/core.c | 271 -------
drivers/crypto/qce/core.h | 64 --
drivers/crypto/qce/dma.c | 135 ----
drivers/crypto/qce/dma.h | 47 --
drivers/crypto/qce/regs-v5.h | 326 --------
drivers/crypto/qce/sha.c | 545 -------------
drivers/crypto/qce/sha.h | 72 --
drivers/crypto/qce/skcipher.c | 529 -------------
20 files changed, 3 insertions(+), 3772 deletions(-)
---
base-commit: 49e05bb00f2e8168695f7af4d694c39e1423e8a2
change-id: 20260523-delete-qce-0363d22a8596
Best regards,
--
Demi Marie Obenour <demiobenour@gmail•com>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 2/2] devicetree: Mark QCE bindings as deprecated
2026-05-23 19:03 [PATCH 0/2] Delete the Qualcomm crypto engine Demi Marie Obenour via B4 Relay
@ 2026-05-23 19:03 ` Demi Marie Obenour via B4 Relay
[not found] ` <20260523-delete-qce-v1-1-86105cd7f406@gmail.com>
1 sibling, 0 replies; 13+ messages in thread
From: Demi Marie Obenour via B4 Relay @ 2026-05-23 19:03 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Thara Gopinath, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Russell King
Cc: linux-kernel, linux-crypto, linux-arm-msm, Eric Biggers,
Ard Biesheuvel, devicetree, linux-arm-kernel, Demi Marie Obenour
From: Demi Marie Obenour <demiobenour@gmail•com>
They are no longer used by the kernel. Keep them to avoid unnecessary
churn and because I know next to nothing about devicetree.
Signed-off-by: Demi Marie Obenour <demiobenour@gmail•com>
---
Documentation/devicetree/bindings/crypto/qcom-qce.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
index 08febd66c22ba8220860f1a59403782d12f8531f..0f378073ddf550ff5954fbe169d5d262a4e46dcf 100644
--- a/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
+++ b/Documentation/devicetree/bindings/crypto/qcom-qce.yaml
@@ -14,6 +14,9 @@ description:
This document defines the binding for the QCE crypto
controller found on Qualcomm parts.
+ This driver is no longer used and so this binding only exists
+ for backwards compatibility.
+
properties:
compatible:
oneOf:
--
2.54.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
[not found] ` <20260523-delete-qce-v1-1-86105cd7f406@gmail.com>
@ 2026-05-24 16:42 ` Dmitry Baryshkov
2026-05-24 20:12 ` Demi Marie Obenour
2026-05-24 20:24 ` Krzysztof Kozlowski
1 sibling, 1 reply; 13+ messages in thread
From: Dmitry Baryshkov @ 2026-05-24 16:42 UTC (permalink / raw)
To: demiobenour
Cc: Herbert Xu, David S. Miller, Thara Gopinath, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Russell King, linux-kernel, linux-crypto, linux-arm-msm,
Eric Biggers, Ard Biesheuvel, devicetree, linux-arm-kernel
On Sat, May 23, 2026 at 03:03:56PM -0400, Demi Marie Obenour via B4 Relay wrote:
> From: Demi Marie Obenour <demiobenour@gmail•com>
>
> It's slower than the generic C code and causes problems.
Which problems?
Also in the security world faster and safer are two orthogonal axis with
very limited correlation.
>
> Signed-off-by: Demi Marie Obenour <demiobenour@gmail•com>
> ---
> MAINTAINERS | 8 -
> arch/arm/configs/multi_v7_defconfig | 1 -
> arch/arm64/configs/defconfig | 1 -
> drivers/crypto/Kconfig | 111 -----
> drivers/crypto/Makefile | 1 -
> drivers/crypto/qce/Makefile | 9 -
> drivers/crypto/qce/aead.c | 841 ------------------------------------
> drivers/crypto/qce/aead.h | 56 ---
> drivers/crypto/qce/cipher.h | 56 ---
> drivers/crypto/qce/common.c | 595 -------------------------
> drivers/crypto/qce/common.h | 104 -----
> drivers/crypto/qce/core.c | 271 ------------
> drivers/crypto/qce/core.h | 64 ---
> drivers/crypto/qce/dma.c | 135 ------
> drivers/crypto/qce/dma.h | 47 --
> drivers/crypto/qce/regs-v5.h | 326 --------------
> drivers/crypto/qce/sha.c | 545 -----------------------
> drivers/crypto/qce/sha.h | 72 ---
> drivers/crypto/qce/skcipher.c | 529 -----------------------
> 19 files changed, 3772 deletions(-)
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
2026-05-24 16:42 ` [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver Dmitry Baryshkov
@ 2026-05-24 20:12 ` Demi Marie Obenour
2026-05-24 20:29 ` Krzysztof Kozlowski
0 siblings, 1 reply; 13+ messages in thread
From: Demi Marie Obenour @ 2026-05-24 20:12 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Herbert Xu, David S. Miller, Thara Gopinath, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Russell King, linux-kernel, linux-crypto, linux-arm-msm,
Eric Biggers, Ard Biesheuvel, devicetree, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1145 bytes --]
On 5/24/26 12:42, Dmitry Baryshkov wrote:
> On Sat, May 23, 2026 at 03:03:56PM -0400, Demi Marie Obenour via B4 Relay wrote:
>> From: Demi Marie Obenour <demiobenour@gmail•com>
>>
>> It's slower than the generic C code and causes problems.
>
> Which problems?
See https://lore.kernel.org/all/20260522024912.GC5937@quark/.
Also, if there are no systems in which the QCE driver is actually
the highest priority, then unless someone adjusts priorities manually
it's unused code.
> Also in the security world faster and safer are two orthogonal axis with
> very limited correlation.
If by "safer" you mean protection against physical side-channel
attacks, then my understanding is that all operations on secret keys
need to be masked. This includes copying and storage.
Linux only supports this for protected keys, and even then sometimes
uses the kernel's own RNG for key generation. There is no support
for using the QCE for protected keys.
Linux does support using hardware-wrapped keys with inline crypto
engines, which are what are actually used on Android.
--
Sincerely,
Demi Marie Obenour (she/her/hers)
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
[not found] ` <20260523-delete-qce-v1-1-86105cd7f406@gmail.com>
2026-05-24 16:42 ` [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver Dmitry Baryshkov
@ 2026-05-24 20:24 ` Krzysztof Kozlowski
1 sibling, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-24 20:24 UTC (permalink / raw)
To: demiobenour, Herbert Xu, David S. Miller, Thara Gopinath,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Russell King
Cc: linux-kernel, linux-crypto, linux-arm-msm, Eric Biggers,
Ard Biesheuvel, devicetree, linux-arm-kernel
On 23/05/2026 21:03, Demi Marie Obenour via B4 Relay wrote:
> From: Demi Marie Obenour <demiobenour@gmail•com>
>
> It's slower than the generic C code and causes problems.
That's really vague and incomplete. You need to make your case, provide
arguments, numbers, data. Otherwise it is just trolling.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
2026-05-24 20:12 ` Demi Marie Obenour
@ 2026-05-24 20:29 ` Krzysztof Kozlowski
2026-05-24 20:31 ` Demi Marie Obenour
2026-05-24 20:45 ` Eric Biggers
0 siblings, 2 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-24 20:29 UTC (permalink / raw)
To: Demi Marie Obenour, Dmitry Baryshkov
Cc: Herbert Xu, David S. Miller, Thara Gopinath, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Russell King, linux-kernel, linux-crypto, linux-arm-msm,
Eric Biggers, Ard Biesheuvel, devicetree, linux-arm-kernel
On 24/05/2026 22:12, Demi Marie Obenour wrote:
> On 5/24/26 12:42, Dmitry Baryshkov wrote:
>> On Sat, May 23, 2026 at 03:03:56PM -0400, Demi Marie Obenour via B4 Relay wrote:
>>> From: Demi Marie Obenour <demiobenour@gmail•com>
>>>
>>> It's slower than the generic C code and causes problems.
>>
>> Which problems?
>
> See https://lore.kernel.org/all/20260522024912.GC5937@quark/.
Your commit is still incomplete and other people's opinion is poor
reason. If you do not know what to write, ask that person to make
necessary changes.
Not mentioning that removing driver is not even necessary to achieve the
goal Eric was mentioning and if I understood correctly: you are removing
even the pieces Eric found useful.
>
> Also, if there are no systems in which the QCE driver is actually
> the highest priority, then unless someone adjusts priorities manually
> it's unused code.
That's not a reason to remove a driver.
>
>> Also in the security world faster and safer are two orthogonal axis with
>> very limited correlation.
>
> If by "safer" you mean protection against physical side-channel
> attacks, then my understanding is that all operations on secret keys
> need to be masked. This includes copying and storage.
>
> Linux only supports this for protected keys, and even then sometimes
> uses the kernel's own RNG for key generation. There is no support
> for using the QCE for protected keys.
>
> Linux does support using hardware-wrapped keys with inline crypto
> engines, which are what are actually used on Android.
Patches are discussed for some time, did you miss that?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
2026-05-24 20:29 ` Krzysztof Kozlowski
@ 2026-05-24 20:31 ` Demi Marie Obenour
2026-05-24 20:45 ` Eric Biggers
1 sibling, 0 replies; 13+ messages in thread
From: Demi Marie Obenour @ 2026-05-24 20:31 UTC (permalink / raw)
To: Krzysztof Kozlowski, Dmitry Baryshkov
Cc: Herbert Xu, David S. Miller, Thara Gopinath, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Konrad Dybcio,
Russell King, linux-kernel, linux-crypto, linux-arm-msm,
Eric Biggers, Ard Biesheuvel, devicetree, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1919 bytes --]
On 5/24/26 16:29, Krzysztof Kozlowski wrote:
> On 24/05/2026 22:12, Demi Marie Obenour wrote:
>> On 5/24/26 12:42, Dmitry Baryshkov wrote:
>>> On Sat, May 23, 2026 at 03:03:56PM -0400, Demi Marie Obenour via B4 Relay wrote:
>>>> From: Demi Marie Obenour <demiobenour@gmail•com>
>>>>
>>>> It's slower than the generic C code and causes problems.
>>>
>>> Which problems?
>>
>> See https://lore.kernel.org/all/20260522024912.GC5937@quark/.
>
> Your commit is still incomplete and other people's opinion is poor
> reason. If you do not know what to write, ask that person to make
> necessary changes.
>
> Not mentioning that removing driver is not even necessary to achieve the
> goal Eric was mentioning and if I understood correctly: you are removing
> even the pieces Eric found useful.
>
>>
>> Also, if there are no systems in which the QCE driver is actually
>> the highest priority, then unless someone adjusts priorities manually
>> it's unused code.
>
> That's not a reason to remove a driver.
>
>
>>
>>> Also in the security world faster and safer are two orthogonal axis with
>>> very limited correlation.
>>
>> If by "safer" you mean protection against physical side-channel
>> attacks, then my understanding is that all operations on secret keys
>> need to be masked. This includes copying and storage.
>>
>> Linux only supports this for protected keys, and even then sometimes
>> uses the kernel's own RNG for key generation. There is no support
>> for using the QCE for protected keys.
>>
>> Linux does support using hardware-wrapped keys with inline crypto
>> engines, which are what are actually used on Android.
>
> Patches are discussed for some time, did you miss that?
>
> Best regards,
> Krzysztof
Thanks for the useful explanation. I'll remove this patch from my
tree and won't resend it.
--
Sincerely,
Demi Marie Obenour (she/her/hers)
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
2026-05-24 20:29 ` Krzysztof Kozlowski
2026-05-24 20:31 ` Demi Marie Obenour
@ 2026-05-24 20:45 ` Eric Biggers
2026-05-25 6:29 ` Kuldeep Singh
2026-05-30 10:48 ` Krzysztof Kozlowski
1 sibling, 2 replies; 13+ messages in thread
From: Eric Biggers @ 2026-05-24 20:45 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Demi Marie Obenour, Dmitry Baryshkov, Herbert Xu, David S. Miller,
Thara Gopinath, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Russell King, linux-kernel,
linux-crypto, linux-arm-msm, Ard Biesheuvel, devicetree,
linux-arm-kernel
On Sun, May 24, 2026 at 10:29:28PM +0200, Krzysztof Kozlowski wrote:
> On 24/05/2026 22:12, Demi Marie Obenour wrote:
> > On 5/24/26 12:42, Dmitry Baryshkov wrote:
> >> On Sat, May 23, 2026 at 03:03:56PM -0400, Demi Marie Obenour via B4 Relay wrote:
> >>> From: Demi Marie Obenour <demiobenour@gmail•com>
> >>>
> >>> It's slower than the generic C code and causes problems.
> >>
> >> Which problems?
> >
> > See https://lore.kernel.org/all/20260522024912.GC5937@quark/.
>
> Your commit is still incomplete and other people's opinion is poor
> reason. If you do not know what to write, ask that person to make
> necessary changes.
>
> Not mentioning that removing driver is not even necessary to achieve the
> goal Eric was mentioning and if I understood correctly: you are removing
> even the pieces Eric found useful.
This driver is more than an order of magnitude slower than the CPU for
both encryption and hashing. See:
https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/
https://lore.kernel.org/r/20250615031807.GA81869@sol/
There are many examples of it having bugs as well, for example see the
second link above.
That's why it had to be disabled via the cra_priority system. This
driver was actively making Linux worse.
This isn't particularly unique to drivers/crypto/, of course. This one
we just have data on, so it's a bit clearer.
I've yet to see any real reason to keep this driver.
Crypto drivers need to be held to a higher standard than other device
drivers, as well. The onus is on those who want to keep a particular
crypto driver to prove that it's worth keeping.
- Eric
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
2026-05-24 20:45 ` Eric Biggers
@ 2026-05-25 6:29 ` Kuldeep Singh
2026-05-25 7:49 ` Demi Marie Obenour
2026-05-25 8:11 ` Dmitry Baryshkov
2026-05-30 10:48 ` Krzysztof Kozlowski
1 sibling, 2 replies; 13+ messages in thread
From: Kuldeep Singh @ 2026-05-25 6:29 UTC (permalink / raw)
To: Eric Biggers, Krzysztof Kozlowski
Cc: Demi Marie Obenour, Dmitry Baryshkov, Herbert Xu, David S. Miller,
Thara Gopinath, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Russell King, linux-kernel,
linux-crypto, linux-arm-msm, Ard Biesheuvel, devicetree,
linux-arm-kernel
> This driver is more than an order of magnitude slower than the CPU for
> both encryption and hashing. See:
>
> https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/
> https://lore.kernel.org/r/20250615031807.GA81869@sol/
>
> There are many examples of it having bugs as well, for example see the
> second link above.
>
> That's why it had to be disabled via the cra_priority system. This
> driver was actively making Linux worse.
>
> This isn't particularly unique to drivers/crypto/, of course. This one
> we just have data on, so it's a bit clearer.
>
> I've yet to see any real reason to keep this driver.
https://lore.kernel.org/all/c1697372-54ec-4f57-85d9-ad375ff1a44d@oss.qualcomm.com/
Kindly check my latest reply to the thread. There are numerous usecases
like DRM(Digital rights management) coming up and qce driver is required
for secure content.
> Crypto drivers need to be held to a higher standard than other device
> drivers, as well. The onus is on those who want to keep a particular
> crypto driver to prove that it's worth keeping.
Sure, I'll be working on stabilizing self_tests infra for qce.
Kindly allow sometime to go over failures in crypto selftest and will
submit fix if applicable.
So far, i am observing 2 ciphers failing(xts-aes-qce and ctr-aes-qce )
with CONFIG_CRYPTO_SELFTESTS enabled.
https://lore.kernel.org/r/20250615031807.GA81869@sol/
May I know how to issue reproduce steps because I didn't observe
crypto/ahash.c failure with CONFIG_CRYPTO_SELFTESTS?
--
Regards
Kuldeep
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
2026-05-25 6:29 ` Kuldeep Singh
@ 2026-05-25 7:49 ` Demi Marie Obenour
2026-05-25 8:11 ` Dmitry Baryshkov
1 sibling, 0 replies; 13+ messages in thread
From: Demi Marie Obenour @ 2026-05-25 7:49 UTC (permalink / raw)
To: Kuldeep Singh, Eric Biggers, Krzysztof Kozlowski
Cc: Dmitry Baryshkov, Herbert Xu, David S. Miller, Thara Gopinath,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson,
Konrad Dybcio, Russell King, linux-kernel, linux-crypto,
linux-arm-msm, Ard Biesheuvel, devicetree, linux-arm-kernel
[-- Attachment #1.1.1: Type: text/plain, Size: 1441 bytes --]
On 5/25/26 02:29, Kuldeep Singh wrote:
>> This driver is more than an order of magnitude slower than the CPU for
>> both encryption and hashing. See:
>>
>> https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/
>> https://lore.kernel.org/r/20250615031807.GA81869@sol/
>>
>> There are many examples of it having bugs as well, for example see the
>> second link above.
>>
>> That's why it had to be disabled via the cra_priority system. This
>> driver was actively making Linux worse.
>>
>> This isn't particularly unique to drivers/crypto/, of course. This one
>> we just have data on, so it's a bit clearer.
>>
>> I've yet to see any real reason to keep this driver.
>
> https://lore.kernel.org/all/c1697372-54ec-4f57-85d9-ad375ff1a44d@oss.qualcomm.com/
> Kindly check my latest reply to the thread. There are numerous usecases
> like DRM(Digital rights management) coming up and qce driver is required
> for secure content.
1. This content is restricted. It's no more secure.
2. General purpose (desktop, laptop) systems won't be able to display
restricted content. To the best of my knowledge, the only Wayland
compositors that support restricted content are Weston and Chromium
OS's compositor.
3. Will this code be useful without out of tree drivers?
4. Does this use the existing crypto APIs or a separate API?
--
Sincerely,
Demi Marie Obenour (she/her/hers)
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 7253 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
2026-05-25 6:29 ` Kuldeep Singh
2026-05-25 7:49 ` Demi Marie Obenour
@ 2026-05-25 8:11 ` Dmitry Baryshkov
2026-05-25 11:10 ` Kuldeep Singh
1 sibling, 1 reply; 13+ messages in thread
From: Dmitry Baryshkov @ 2026-05-25 8:11 UTC (permalink / raw)
To: Kuldeep Singh
Cc: Eric Biggers, Krzysztof Kozlowski, Demi Marie Obenour, Herbert Xu,
David S. Miller, Thara Gopinath, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Russell King,
linux-kernel, linux-crypto, linux-arm-msm, Ard Biesheuvel,
devicetree, linux-arm-kernel
On Mon, May 25, 2026 at 11:59:33AM +0530, Kuldeep Singh wrote:
> > This driver is more than an order of magnitude slower than the CPU for
> > both encryption and hashing. See:
> >
> > https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/
> > https://lore.kernel.org/r/20250615031807.GA81869@sol/
> >
> > There are many examples of it having bugs as well, for example see the
> > second link above.
> >
> > That's why it had to be disabled via the cra_priority system. This
> > driver was actively making Linux worse.
> >
> > This isn't particularly unique to drivers/crypto/, of course. This one
> > we just have data on, so it's a bit clearer.
> >
> > I've yet to see any real reason to keep this driver.
>
> https://lore.kernel.org/all/c1697372-54ec-4f57-85d9-ad375ff1a44d@oss.qualcomm.com/
> Kindly check my latest reply to the thread. There are numerous usecases
> like DRM(Digital rights management) coming up and qce driver is required
> for secure content.
>
> > Crypto drivers need to be held to a higher standard than other device
> > drivers, as well. The onus is on those who want to keep a particular
> > crypto driver to prove that it's worth keeping.
> Sure, I'll be working on stabilizing self_tests infra for qce.
> Kindly allow sometime to go over failures in crypto selftest and will
> submit fix if applicable.
Why are not selftests a part of your default config? How are you testing
the driver?
> So far, i am observing 2 ciphers failing(xts-aes-qce and ctr-aes-qce )
> with CONFIG_CRYPTO_SELFTESTS enabled.
Please make sure to run the tests on older platforms too, not just the
latest & greatest.
>
> https://lore.kernel.org/r/20250615031807.GA81869@sol/
> May I know how to issue reproduce steps because I didn't observe
> crypto/ahash.c failure with CONFIG_CRYPTO_SELFTESTS?
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
2026-05-25 8:11 ` Dmitry Baryshkov
@ 2026-05-25 11:10 ` Kuldeep Singh
0 siblings, 0 replies; 13+ messages in thread
From: Kuldeep Singh @ 2026-05-25 11:10 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Eric Biggers, Krzysztof Kozlowski, Demi Marie Obenour, Herbert Xu,
David S. Miller, Thara Gopinath, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Bjorn Andersson, Konrad Dybcio, Russell King,
linux-kernel, linux-crypto, linux-arm-msm, Ard Biesheuvel,
devicetree, linux-arm-kernel
On 25-05-2026 13:41, Dmitry Baryshkov wrote:
> On Mon, May 25, 2026 at 11:59:33AM +0530, Kuldeep Singh wrote:
>>> This driver is more than an order of magnitude slower than the CPU for
>>> both encryption and hashing. See:
>>>
>>> https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/
>>> https://lore.kernel.org/r/20250615031807.GA81869@sol/
>>>
>>> There are many examples of it having bugs as well, for example see the
>>> second link above.
>>>
>>> That's why it had to be disabled via the cra_priority system. This
>>> driver was actively making Linux worse.
>>>
>>> This isn't particularly unique to drivers/crypto/, of course. This one
>>> we just have data on, so it's a bit clearer.
>>>
>>> I've yet to see any real reason to keep this driver.
>>
>> https://lore.kernel.org/all/c1697372-54ec-4f57-85d9-ad375ff1a44d@oss.qualcomm.com/
>> Kindly check my latest reply to the thread. There are numerous usecases
>> like DRM(Digital rights management) coming up and qce driver is required
>> for secure content.
>>
>>> Crypto drivers need to be held to a higher standard than other device
>>> drivers, as well. The onus is on those who want to keep a particular
>>> crypto driver to prove that it's worth keeping.
>> Sure, I'll be working on stabilizing self_tests infra for qce.
>> Kindly allow sometime to go over failures in crypto selftest and will
>> submit fix if applicable.
>
> Why are not selftests a part of your default config? How are you testing
> the driver?
We are validating the driver probe and kcapi userspace tests while
validating qce algos. Locally we update all 3 algo priority and then run
kcapi_convinience.sh test suite to ensure it picks qce algos.
Please note, previously were not aware need to run selftests suite too.
Got to know about this once issue was reported.
>
>> So far, i am observing 2 ciphers failing(xts-aes-qce and ctr-aes-qce )
>> with CONFIG_CRYPTO_SELFTESTS enabled.
>
> Please make sure to run the tests on older platforms too, not just the
> latest & greatest.
Yes, will check on all the platforms.
--
Regards
Kuldeep
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver
2026-05-24 20:45 ` Eric Biggers
2026-05-25 6:29 ` Kuldeep Singh
@ 2026-05-30 10:48 ` Krzysztof Kozlowski
1 sibling, 0 replies; 13+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-30 10:48 UTC (permalink / raw)
To: Eric Biggers
Cc: Demi Marie Obenour, Dmitry Baryshkov, Herbert Xu, David S. Miller,
Thara Gopinath, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Bjorn Andersson, Konrad Dybcio, Russell King, linux-kernel,
linux-crypto, linux-arm-msm, Ard Biesheuvel, devicetree,
linux-arm-kernel
On Sun, May 24, 2026 at 03:45:37PM -0500, Eric Biggers wrote:
> On Sun, May 24, 2026 at 10:29:28PM +0200, Krzysztof Kozlowski wrote:
> > On 24/05/2026 22:12, Demi Marie Obenour wrote:
> > > On 5/24/26 12:42, Dmitry Baryshkov wrote:
> > >> On Sat, May 23, 2026 at 03:03:56PM -0400, Demi Marie Obenour via B4 Relay wrote:
> > >>> From: Demi Marie Obenour <demiobenour@gmail•com>
> > >>>
> > >>> It's slower than the generic C code and causes problems.
> > >>
> > >> Which problems?
> > >
> > > See https://lore.kernel.org/all/20260522024912.GC5937@quark/.
> >
> > Your commit is still incomplete and other people's opinion is poor
> > reason. If you do not know what to write, ask that person to make
> > necessary changes.
> >
> > Not mentioning that removing driver is not even necessary to achieve the
> > goal Eric was mentioning and if I understood correctly: you are removing
> > even the pieces Eric found useful.
>
> This driver is more than an order of magnitude slower than the CPU for
> both encryption and hashing. See:
>
> https://lore.kernel.org/r/20250704070322.20692-1-ebiggers@kernel.org/
> https://lore.kernel.org/r/20250615031807.GA81869@sol/
>
> There are many examples of it having bugs as well, for example see the
> second link above.
>
> That's why it had to be disabled via the cra_priority system. This
> driver was actively making Linux worse.
>
> This isn't particularly unique to drivers/crypto/, of course. This one
> we just have data on, so it's a bit clearer.
>
> I've yet to see any real reason to keep this driver.
>
> Crypto drivers need to be held to a higher standard than other device
> drivers, as well. The onus is on those who want to keep a particular
> crypto driver to prove that it's worth keeping.
Commit doing the work should have all these explanations, including
numbers. External references are not a proper justification for commits.
Make your case, describe the findings including impact (or lack of
impact) on ongoing hw wrapped keys work and inlined encryption for other
devices (ICE).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2026-05-30 10:48 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-23 19:03 [PATCH 0/2] Delete the Qualcomm crypto engine Demi Marie Obenour via B4 Relay
2026-05-23 19:03 ` [PATCH 2/2] devicetree: Mark QCE bindings as deprecated Demi Marie Obenour via B4 Relay
[not found] ` <20260523-delete-qce-v1-1-86105cd7f406@gmail.com>
2026-05-24 16:42 ` [PATCH 1/2] crypto: Delete Qualcomm crypto engine driver Dmitry Baryshkov
2026-05-24 20:12 ` Demi Marie Obenour
2026-05-24 20:29 ` Krzysztof Kozlowski
2026-05-24 20:31 ` Demi Marie Obenour
2026-05-24 20:45 ` Eric Biggers
2026-05-25 6:29 ` Kuldeep Singh
2026-05-25 7:49 ` Demi Marie Obenour
2026-05-25 8:11 ` Dmitry Baryshkov
2026-05-25 11:10 ` Kuldeep Singh
2026-05-30 10:48 ` Krzysztof Kozlowski
2026-05-24 20:24 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox