public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Tejun Heo <tj@kernel•org>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Jon Masters <jcm@jonmasters•org>
Subject: linux-next: build failure after merge of the slabh tree
Date: Mon, 29 Mar 2010 15:42:08 +1100	[thread overview]
Message-ID: <20100329154208.009a8ae2.sfr@canb.auug.org.au> (raw)

Hi Tejun,

After merging the slabh tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/misc/hwlat_detector.c: In function 'debug_sample_fread':
drivers/misc/hwlat_detector.c:713: error: implicit declaration of function 'kzalloc'
drivers/misc/hwlat_detector.c:713: warning: assignment makes pointer from integer without a cast
drivers/misc/hwlat_detector.c:755: error: implicit declaration of function 'kfree'

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 94366eaeaf5ac4831637de39eac48ca62afe4e2a ("hwlat_detector: A
system hardware latency detector") from the hwlat tree.

I applied the following merge fixup which should be applied to the hwlat
tree anyway, please Jon (see Documentation/SubmitChecklist Rule #1 :-))?

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 29 Mar 2010 15:38:45 +1100
Subject: [PATCH] hwlat: using kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 drivers/misc/hwlat_detector.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/hwlat_detector.c b/drivers/misc/hwlat_detector.c
index e02d8e1..a56baf4 100644
--- a/drivers/misc/hwlat_detector.c
+++ b/drivers/misc/hwlat_detector.c
@@ -50,6 +50,7 @@
 #include <linux/uaccess.h>
 #include <linux/version.h>
 #include <linux/delay.h>
+#include <linux/slab.h>
 
 #define BUF_SIZE_DEFAULT	262144UL		/* 8K*(sizeof(entry)) */
 #define BUF_FLAGS		(RB_FL_OVERWRITE)	/* no block on full */
-- 
1.7.0.3


-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

             reply	other threads:[~2010-03-29  4:42 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29  4:42 Stephen Rothwell [this message]
2010-03-29 16:25 ` [PATCH -next] kmemcheck: build failure after merge of the slabh tree Randy Dunlap
2010-03-29 18:00   ` Tejun Heo
2010-03-29 18:11     ` Tejun Heo
2010-03-30 12:14 ` linux-next: " Jon Masters
2010-03-30 13:45   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2010-03-29  5:02 Stephen Rothwell
2010-03-30 19:32 ` Jason Wessel
2010-03-30 22:49   ` Stephen Rothwell
2010-03-29  5:02 Stephen Rothwell
2010-03-29  6:28 ` Takashi Iwai
2010-03-29  6:38   ` Stephen Rothwell
2010-03-29  8:01     ` Stephen Rothwell
2010-03-29  8:05       ` Takashi Iwai
2010-03-29 11:10     ` Tejun Heo
2010-03-29 12:25       ` Stephen Rothwell
2010-03-29  5:02 Stephen Rothwell
2010-03-29 22:33 ` Dan Williams
2010-03-29 23:16   ` Stephen Rothwell
2010-03-29  5:28 Stephen Rothwell
2010-03-29  5:28 Stephen Rothwell
2010-03-29  5:29 Stephen Rothwell
2010-03-29  5:34 Stephen Rothwell
2010-03-29  5:39 Stephen Rothwell
2010-03-29  5:47 Stephen Rothwell
2010-03-29  5:53 Stephen Rothwell
2010-03-29  5:59 Stephen Rothwell
2010-03-29  6:07 Stephen Rothwell
2010-05-19 16:23 ` Stephen Rothwell
2010-03-29  6:55 Stephen Rothwell
2010-03-29  7:34 ` Takashi Iwai
2010-04-01  5:41 Stephen Rothwell
2010-04-01  7:29 ` David Miller
2010-04-01  7:31   ` Tejun Heo
2010-04-01  7:40   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100329154208.009a8ae2.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=jcm@jonmasters$(echo .)org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=tj@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox