From: Takashi Iwai <tiwai@suse•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Tejun Heo <tj@kernel•org>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Daniel Mack <daniel@caiaq•de>
Subject: Re: linux-next: build failure after merge of the slabh tree
Date: Mon, 29 Mar 2010 08:28:09 +0200 [thread overview]
Message-ID: <s5hy6hb4p6u.wl%tiwai@suse.de> (raw)
In-Reply-To: <20100329160250.1515a2ca.sfr@canb.auug.org.au>
At Mon, 29 Mar 2010 16:02:50 +1100,
Stephen Rothwell wrote:
>
> Hi Tejun,
>
> After merging the slabh tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> sound/usb/mixer_quirks.c: In function 'snd_usb_soundblaster_remote_init':
> sound/usb/mixer_quirks.c:144: error: implicit declaration of function 'kmalloc'
> sound/usb/mixer_quirks.c:144: warning: assignment makes pointer from integer without a cast
>
> Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
> implicitly include slab.h from percpu.h") from the slabh tree interacting
> with commit 7b1eda223debcba706ab989a09c4eecb327aebdf ("ALSA: usb-mixer:
> factor out quirks") from the sound tree.
>
> I applied the following merge fixup patch which should be applied to the
> sound tree (see Documentation/SubmitChecklist Rule #1 :-)).
Thanks, I applied all these oneliners to sound/usb/* as a single
patch now.
Takashi
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Mon, 29 Mar 2010 15:59:58 +1100
> Subject: [PATCH] sound: use of kmalloc requires the include of slab.h
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
> ---
> sound/usb/mixer_quirks.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/usb/mixer_quirks.c b/sound/usb/mixer_quirks.c
> index 56b6659..e7df1e5 100644
> --- a/sound/usb/mixer_quirks.c
> +++ b/sound/usb/mixer_quirks.c
> @@ -26,6 +26,7 @@
> */
>
> #include <linux/init.h>
> +#include <linux/slab.h>
> #include <linux/usb.h>
> #include <linux/usb/audio.h>
>
> --
> 1.7.0.3
>
> --
> Cheers,
> Stephen Rothwell sfr@canb•auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
next prev parent reply other threads:[~2010-03-29 6:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 5:02 linux-next: build failure after merge of the slabh tree Stephen Rothwell
2010-03-29 6:28 ` Takashi Iwai [this message]
2010-03-29 6:38 ` Stephen Rothwell
2010-03-29 8:01 ` Stephen Rothwell
2010-03-29 8:05 ` Takashi Iwai
2010-03-29 11:10 ` Tejun Heo
2010-03-29 12:25 ` Stephen Rothwell
-- strict thread matches above, loose matches on Subject: below --
2010-04-01 5:41 Stephen Rothwell
2010-04-01 7:29 ` David Miller
2010-04-01 7:31 ` Tejun Heo
2010-04-01 7:40 ` Stephen Rothwell
2010-03-29 6:55 Stephen Rothwell
2010-03-29 7:34 ` Takashi Iwai
2010-03-29 6:07 Stephen Rothwell
2010-05-19 16:23 ` Stephen Rothwell
2010-03-29 5:59 Stephen Rothwell
2010-03-29 5:53 Stephen Rothwell
2010-03-29 5:47 Stephen Rothwell
2010-03-29 5:39 Stephen Rothwell
2010-03-29 5:34 Stephen Rothwell
2010-03-29 5:29 Stephen Rothwell
2010-03-29 5:28 Stephen Rothwell
2010-03-29 5:28 Stephen Rothwell
2010-03-29 5:02 Stephen Rothwell
2010-03-29 22:33 ` Dan Williams
2010-03-29 23:16 ` Stephen Rothwell
2010-03-29 5:02 Stephen Rothwell
2010-03-30 19:32 ` Jason Wessel
2010-03-30 22:49 ` Stephen Rothwell
2010-03-29 4:42 Stephen Rothwell
2010-03-30 12:14 ` Jon Masters
2010-03-30 13:45 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5hy6hb4p6u.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=daniel@caiaq$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tj@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox