From: Takashi Iwai <tiwai@suse•de>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: Tejun Heo <tj@kernel•org>,
linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
Misael Lopez Cruz <x0052729@ti•com>,
Jorge Eduardo Candelaria <jorge.candelaria@ti•com>,
Margarita Olaya Cabrera <magi.olaya@ti•com>,
Mark Brown <broonie@opensource•wolfsonmicro.com>
Subject: Re: linux-next: build failure after merge of the slabh tree
Date: Mon, 29 Mar 2010 09:34:26 +0200 [thread overview]
Message-ID: <s5haatr4m4d.wl%tiwai@suse.de> (raw)
In-Reply-To: <20100329175551.873d9fab.sfr@canb.auug.org.au>
At Mon, 29 Mar 2010 17:55:51 +1100,
Stephen Rothwell wrote:
>
> Hi Tejun,
>
> After merging the slabh tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> sound/soc/codecs/twl6040.c: In function 'twl6040_remove':
> sound/soc/codecs/twl6040.c:1052: error: implicit declaration of function 'kfree'
> sound/soc/codecs/twl6040.c: In function 'twl6040_codec_probe':
> sound/soc/codecs/twl6040.c:1073: error: implicit declaration of function 'kzalloc'
> sound/soc/codecs/twl6040.c:1073: warning: assignment makes pointer from integer without a cast
>
> Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
> implicitly include slab.h from percpu.h") from the slabh tree interacting
> with commit 8ecbabd977dc64d2d8c9980420a3d72db06fe551 ("ASoC: TWL6040: Add
> twl6040 codec driver") from the sound tree.
>
> I applied the following merge fixup patch which should be applied to the
> sound tree (see Documentation/SubmitChecklist Rule #1 :-)). Hi Takashi,
> another one. :-(
>
> From: Stephen Rothwell <sfr@canb•auug.org.au>
> Date: Mon, 29 Mar 2010 17:52:52 +1100
> Subject: [PATCH] Asoc: TWL6040: use of kzalloc/kfree requires the include of slab.h
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
Applied to sound tree. Thanks.
Takashi
> ---
> sound/soc/codecs/twl6040.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
> index 0e4dce7..108c51a 100755
> --- a/sound/soc/codecs/twl6040.c
> +++ b/sound/soc/codecs/twl6040.c
> @@ -27,6 +27,7 @@
> #include <linux/i2c.h>
> #include <linux/gpio.h>
> #include <linux/platform_device.h>
> +#include <linux/slab.h>
> #include <linux/i2c/twl.h>
>
> #include <sound/core.h>
> --
> 1.7.0.3
>
> --
> Cheers,
> Stephen Rothwell sfr@canb•auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
next prev parent reply other threads:[~2010-03-29 7:34 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 6:55 linux-next: build failure after merge of the slabh tree Stephen Rothwell
2010-03-29 7:34 ` Takashi Iwai [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-04-01 5:41 Stephen Rothwell
2010-04-01 7:29 ` David Miller
2010-04-01 7:31 ` Tejun Heo
2010-04-01 7:40 ` Stephen Rothwell
2010-03-29 6:07 Stephen Rothwell
2010-05-19 16:23 ` Stephen Rothwell
2010-03-29 5:59 Stephen Rothwell
2010-03-29 5:53 Stephen Rothwell
2010-03-29 5:47 Stephen Rothwell
2010-03-29 5:39 Stephen Rothwell
2010-03-29 5:34 Stephen Rothwell
2010-03-29 5:29 Stephen Rothwell
2010-03-29 5:28 Stephen Rothwell
2010-03-29 5:28 Stephen Rothwell
2010-03-29 5:02 Stephen Rothwell
2010-03-29 22:33 ` Dan Williams
2010-03-29 23:16 ` Stephen Rothwell
2010-03-29 5:02 Stephen Rothwell
2010-03-29 6:28 ` Takashi Iwai
2010-03-29 6:38 ` Stephen Rothwell
2010-03-29 8:01 ` Stephen Rothwell
2010-03-29 8:05 ` Takashi Iwai
2010-03-29 11:10 ` Tejun Heo
2010-03-29 12:25 ` Stephen Rothwell
2010-03-29 5:02 Stephen Rothwell
2010-03-30 19:32 ` Jason Wessel
2010-03-30 22:49 ` Stephen Rothwell
2010-03-29 4:42 Stephen Rothwell
2010-03-30 12:14 ` Jon Masters
2010-03-30 13:45 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5haatr4m4d.wl%tiwai@suse.de \
--to=tiwai@suse$(echo .)de \
--cc=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=jorge.candelaria@ti$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-next@vger$(echo .)kernel.org \
--cc=magi.olaya@ti$(echo .)com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=tj@kernel$(echo .)org \
--cc=x0052729@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox