public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Tejun Heo <tj@kernel•org>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Jason Wessel <jason.wessel@windriver•com>,
	Martin Hicks <mort@sgi•com>
Subject: linux-next: build failure after merge of the slabh tree
Date: Mon, 29 Mar 2010 16:02:48 +1100	[thread overview]
Message-ID: <20100329160248.e15e7836.sfr@canb.auug.org.au> (raw)

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

kernel/debug/kdb/kdb_support.c: In function 'kdb_strdup':
kernel/debug/kdb/kdb_support.c:309: error: implicit declaration of function 'kmalloc'
kernel/debug/kdb/kdb_support.c:309: warning: initialization makes pointer from integer without a cast
kernel/debug/kdb/kdb_support.c: In function 'debug_kfree':
kernel/debug/kdb/kdb_support.c:810: error: implicit declaration of function 'kfree'

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 5572dd736e5577dfefafe2ad3b54760e8323e33d ("kdb: core for kgdb
back end (1 of 2)") from the kgdb tree.

I applied the following merge fixup patch which should be applied to the
kdbg tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 29 Mar 2010 15:49:05 +1100
Subject: [PATCH] kgdb: use of kmalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 kernel/debug/kdb/kdb_support.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/debug/kdb/kdb_support.c b/kernel/debug/kdb/kdb_support.c
index 788dbfe..45344d5 100644
--- a/kernel/debug/kdb/kdb_support.c
+++ b/kernel/debug/kdb/kdb_support.c
@@ -24,6 +24,7 @@
 #include <linux/delay.h>
 #include <linux/uaccess.h>
 #include <linux/kdb.h>
+#include <linux/slab.h>
 #include "kdb_private.h"
 
 /*
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

             reply	other threads:[~2010-03-29  6:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29  5:02 Stephen Rothwell [this message]
2010-03-30 19:32 ` linux-next: build failure after merge of the slabh tree Jason Wessel
2010-03-30 22:49   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2010-04-01  5:41 Stephen Rothwell
2010-04-01  7:29 ` David Miller
2010-04-01  7:31   ` Tejun Heo
2010-04-01  7:40   ` Stephen Rothwell
2010-03-29  6:55 Stephen Rothwell
2010-03-29  7:34 ` Takashi Iwai
2010-03-29  6:07 Stephen Rothwell
2010-05-19 16:23 ` Stephen Rothwell
2010-03-29  5:59 Stephen Rothwell
2010-03-29  5:53 Stephen Rothwell
2010-03-29  5:47 Stephen Rothwell
2010-03-29  5:39 Stephen Rothwell
2010-03-29  5:34 Stephen Rothwell
2010-03-29  5:29 Stephen Rothwell
2010-03-29  5:28 Stephen Rothwell
2010-03-29  5:28 Stephen Rothwell
2010-03-29  5:02 Stephen Rothwell
2010-03-29 22:33 ` Dan Williams
2010-03-29 23:16   ` Stephen Rothwell
2010-03-29  5:02 Stephen Rothwell
2010-03-29  6:28 ` Takashi Iwai
2010-03-29  6:38   ` Stephen Rothwell
2010-03-29  8:01     ` Stephen Rothwell
2010-03-29  8:05       ` Takashi Iwai
2010-03-29 11:10     ` Tejun Heo
2010-03-29 12:25       ` Stephen Rothwell
2010-03-29  4:42 Stephen Rothwell
2010-03-30 12:14 ` Jon Masters
2010-03-30 13:45   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100329160248.e15e7836.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=jason.wessel@windriver$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=mort@sgi$(echo .)com \
    --cc=tj@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox