public inbox for linux-next@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb•auug.org.au>
To: Tejun Heo <tj@kernel•org>
Cc: linux-next@vger•kernel.org, linux-kernel@vger•kernel.org,
	Bryan Wu <cooloney@kernel•org>,
	Dmitry Torokhov <dmitry.torokhov@gmail•com>
Subject: linux-next: build failure after merge of the slabh tree
Date: Mon, 29 Mar 2010 16:47:48 +1100	[thread overview]
Message-ID: <20100329164748.e1e16358.sfr@canb.auug.org.au> (raw)

Hi Tejun,

After merging the slabh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/input/misc/pcf8574_keypad.c: In function 'pcf8574_kp_probe':
drivers/input/misc/pcf8574_keypad.c:95: error: implicit declaration of function 'kzalloc'
drivers/input/misc/pcf8574_keypad.c:95: warning: assignment makes pointer from integer without a cast
drivers/input/misc/pcf8574_keypad.c:156: error: implicit declaration of function 'kfree'

Caused by commit d103d3b3e8512312b5254950035366d4422a479a ("percpu: don't
implicitly include slab.h from percpu.h") from the slabh tree interacting
with commit 88643169de358b8e5af101151d913ad80e4c64df ("Input: add PCF8574
I2C keypad input device driver") from the input tree.

I applied the following merge fixup patch which should be applied to the
input tree (see Documentation/SubmitChecklist Rule #1 :-)).

From: Stephen Rothwell <sfr@canb•auug.org.au>
Date: Mon, 29 Mar 2010 16:45:42 +1100
Subject: [PATCH] input: pcf8574_keypad: use of kzalloc/kfree requires the include of slab.h

Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
---
 drivers/input/misc/pcf8574_keypad.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/input/misc/pcf8574_keypad.c b/drivers/input/misc/pcf8574_keypad.c
index cb135e5..5c3ac4e 100644
--- a/drivers/input/misc/pcf8574_keypad.c
+++ b/drivers/input/misc/pcf8574_keypad.c
@@ -11,6 +11,7 @@
 #include <linux/input.h>
 #include <linux/interrupt.h>
 #include <linux/i2c.h>
+#include <linux/slab.h>
 #include <linux/workqueue.h>
 
 #define DRV_NAME "pcf8574_keypad"
-- 
1.7.0.3

-- 
Cheers,
Stephen Rothwell                    sfr@canb•auug.org.au
http://www.canb.auug.org.au/~sfr/

             reply	other threads:[~2010-03-29  6:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29  5:47 Stephen Rothwell [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-04-01  5:41 linux-next: build failure after merge of the slabh tree Stephen Rothwell
2010-04-01  7:29 ` David Miller
2010-04-01  7:31   ` Tejun Heo
2010-04-01  7:40   ` Stephen Rothwell
2010-03-29  6:55 Stephen Rothwell
2010-03-29  7:34 ` Takashi Iwai
2010-03-29  6:07 Stephen Rothwell
2010-05-19 16:23 ` Stephen Rothwell
2010-03-29  5:59 Stephen Rothwell
2010-03-29  5:53 Stephen Rothwell
2010-03-29  5:39 Stephen Rothwell
2010-03-29  5:34 Stephen Rothwell
2010-03-29  5:29 Stephen Rothwell
2010-03-29  5:28 Stephen Rothwell
2010-03-29  5:28 Stephen Rothwell
2010-03-29  5:02 Stephen Rothwell
2010-03-29 22:33 ` Dan Williams
2010-03-29 23:16   ` Stephen Rothwell
2010-03-29  5:02 Stephen Rothwell
2010-03-29  6:28 ` Takashi Iwai
2010-03-29  6:38   ` Stephen Rothwell
2010-03-29  8:01     ` Stephen Rothwell
2010-03-29  8:05       ` Takashi Iwai
2010-03-29 11:10     ` Tejun Heo
2010-03-29 12:25       ` Stephen Rothwell
2010-03-29  5:02 Stephen Rothwell
2010-03-30 19:32 ` Jason Wessel
2010-03-30 22:49   ` Stephen Rothwell
2010-03-29  4:42 Stephen Rothwell
2010-03-30 12:14 ` Jon Masters
2010-03-30 13:45   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100329164748.e1e16358.sfr@canb.auug.org.au \
    --to=sfr@canb$(echo .)auug.org.au \
    --cc=cooloney@kernel$(echo .)org \
    --cc=dmitry.torokhov@gmail$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-next@vger$(echo .)kernel.org \
    --cc=tj@kernel$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox